Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Kevin Rushforth 
On Wed, 2 Mar 2022 15:26:35 GMT, Devin Smith  wrote:

> Thanks for the help. I signed the OCA on Jan 17, 2022 and got confirmation it 
> was approved on Jan 20, 2022.

Correct. Reviewers may know that this has been recorded if the PR has no `oca` 
label (you can see above that the `oca` label was removed on Jan 20).

-

PR: https://git.openjdk.java.net/jdk/pull/7120

Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Devin Smith 
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith  wrote:

> Did a cursory review of the other generators, they seem to set the state 
> correctly.

Thanks for the help. I signed the OCA on Jan 17, 2022 and got confirmation it 
was approved on Jan 20, 2022.

-

PR: https://git.openjdk.java.net/jdk/pull/7120

Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Devin Smith 
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith  wrote:

> Did a cursory review of the other generators, they seem to set the state 
> correctly.

@JimLaskey would it be possible to create an issue and review this change? I 
don't have an account on the OpenJDK issue tracker.

I'm not sure how to move this forward, or get the attention of the people 
responsible for this code. I see @turbanoff you liked and may be involved w/ 
OpenJDK?

-

PR: https://git.openjdk.java.net/jdk/pull/7120

Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Daniel Jeliński 
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith  wrote:

> Did a cursory review of the other generators, they seem to set the state 
> correctly.

Created https://bugs.openjdk.java.net/browse/JDK-8282551 for this.
@devinrsmith please change the issue title to `8282551: Properly initialize 
L32X64MixRandom state`, then it should be picked up by bots.

-

PR: https://git.openjdk.java.net/jdk/pull/7120

Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Daniel Jeliński 
On Mon, 21 Feb 2022 19:43:52 GMT, Devin Smith  wrote:

>> Did a cursory review of the other generators, they seem to set the state 
>> correctly.
>
> I'm not sure how to move this forward, or get the attention of the people 
> responsible for this code. I see @turbanoff you liked and may be involved w/ 
> OpenJDK?

Hi @devinrsmith, pull requests in openjdk organization are not actively 
monitored. 
You should send a note to 
[core-libs-dev](https://mail.openjdk.java.net/mailman/listinfo/core-libs-dev) 
(subscription required), and someone will guide you from there.

-

PR: https://git.openjdk.java.net/jdk/pull/7120

RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Devin Smith 
Did a cursory review of the other generators, they seem to set the state 
correctly.

-

Commit messages:
 - [PATCH] Properly initialize L32X64MixRandom state

Changes: https://git.openjdk.java.net/jdk/pull/7120/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7120=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8282551
  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7120.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7120/head:pull/7120

PR: https://git.openjdk.java.net/jdk/pull/7120

Re: RFR: 8282551: Properly initialize L32X64MixRandom state

2022-03-02 Thread Jim Laskey 
On Tue, 18 Jan 2022 01:39:52 GMT, Devin Smith  wrote:

> Did a cursory review of the other generators, they seem to set the state 
> correctly.

Marked as reviewed by jlaskey (Reviewer).

I'll sponsor this change when you receive your OCA.

-

PR: https://git.openjdk.java.net/jdk/pull/7120