Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

2022-05-16 Thread Jaikiran Pai
On Mon, 16 May 2022 22:06:25 GMT, Leonid Mesnik  wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   copyright year
>
> Looks reasonable.

Thank you @lmesnik  for the review.

-

PR: https://git.openjdk.java.net/jdk/pull/8703


Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

2022-05-16 Thread Leonid Mesnik
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai  wrote:

>> Can I please get a review of this change which proposes to fix the failure 
>> handler command `dmesg` on macOS?
>> 
>> As noted in the JBS issue, the command currently fails with permission 
>> error. The commit in this PR uses `sudo` as suggested in the man pages of 
>> that command.
>> 
>> Tested locally on macOS by running:
>> 
>> 
>> cd test/failure_handler
>> make clean
>> make test
>> 
>> Then checked the generated environment.html files for the dmesg command 
>> output. Looks fine after this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   copyright year

Looks reasonable.

-

Marked as reviewed by lmesnik (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8703


Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

2022-05-16 Thread David Holmes
On Mon, 16 May 2022 07:54:09 GMT, Jaikiran Pai  wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   copyright year
>
> Thank you Daniel and Lance for the reviews. 
> 
> Would anyone from the build team like to provide any additional reviews?

@jaikiran  this is more a SQE issue that an build issue. @lmesnik may have an 
opinion.

-

PR: https://git.openjdk.java.net/jdk/pull/8703


Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

2022-05-16 Thread Jaikiran Pai
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai  wrote:

>> Can I please get a review of this change which proposes to fix the failure 
>> handler command `dmesg` on macOS?
>> 
>> As noted in the JBS issue, the command currently fails with permission 
>> error. The commit in this PR uses `sudo` as suggested in the man pages of 
>> that command.
>> 
>> Tested locally on macOS by running:
>> 
>> 
>> cd test/failure_handler
>> make clean
>> make test
>> 
>> Then checked the generated environment.html files for the dmesg command 
>> output. Looks fine after this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   copyright year

Thank you Daniel and Lance for the reviews. 

Would anyone from the build team provide any additional reviews?

-

PR: https://git.openjdk.java.net/jdk/pull/8703


Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

2022-05-13 Thread Lance Andersen
On Fri, 13 May 2022 14:39:44 GMT, Jaikiran Pai  wrote:

>> Can I please get a review of this change which proposes to fix the failure 
>> handler command `dmesg` on macOS?
>> 
>> As noted in the JBS issue, the command currently fails with permission 
>> error. The commit in this PR uses `sudo` as suggested in the man pages of 
>> that command.
>> 
>> Tested locally on macOS by running:
>> 
>> 
>> cd test/failure_handler
>> make clean
>> make test
>> 
>> Then checked the generated environment.html files for the dmesg command 
>> output. Looks fine after this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   copyright year

looks ok to me

-

Marked as reviewed by lancea (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8703


Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

2022-05-13 Thread Daniel Fuchs
On Fri, 13 May 2022 14:36:02 GMT, Jaikiran Pai  wrote:

>> Can I please get a review of this change which proposes to fix the failure 
>> handler command `dmesg` on macOS?
>> 
>> As noted in the JBS issue, the command currently fails with permission 
>> error. The commit in this PR uses `sudo` as suggested in the man pages of 
>> that command.
>> 
>> Tested locally on macOS by running:
>> 
>> 
>> cd test/failure_handler
>> make clean
>> make test
>> 
>> Then checked the generated environment.html files for the dmesg command 
>> output. Looks fine after this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   copyright year

LGTM

-

Marked as reviewed by dfuchs (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8703


Re: RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues [v2]

2022-05-13 Thread Jaikiran Pai
> Can I please get a review of this change which proposes to fix the failure 
> handler command `dmesg` on macOS?
> 
> As noted in the JBS issue, the command currently fails with permission error. 
> The commit in this PR uses `sudo` as suggested in the man pages of that 
> command.
> 
> Tested locally on macOS by running:
> 
> 
> cd test/failure_handler
> make clean
> make test
> 
> Then checked the generated environment.html files for the dmesg command 
> output. Looks fine after this change.

Jaikiran Pai has updated the pull request incrementally with one additional 
commit since the last revision:

  copyright year

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8703/files
  - new: https://git.openjdk.java.net/jdk/pull/8703/files/db538083..f85acab5

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8703=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8703=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8703.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8703/head:pull/8703

PR: https://git.openjdk.java.net/jdk/pull/8703


RFR: 8286744: failure_handler: dmesg command on macos fails to collect data due to permission issues

2022-05-13 Thread Jaikiran Pai
Can I please get a review of this change which proposes to fix the failure 
handler command `dmesg` on macOS?

As noted in the JBS issue, the command currently fails with permission error. 
The commit in this PR uses `sudo` as suggested in the man pages of that command.

Tested locally on macOS by running:


cd test/failure_handler
make clean
make test

Then checked the generated environment.html files for the dmesg command output. 
Looks fine after this change.

-

Commit messages:
 - 8286744: use sudo dmesg on macos for failure handler

Changes: https://git.openjdk.java.net/jdk/pull/8703/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8703=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8286744
  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8703.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8703/head:pull/8703

PR: https://git.openjdk.java.net/jdk/pull/8703