Re: RFR: 8287663 Add a regression test for JDK-8287073

2022-06-07 Thread Severin Gehwolf
On Tue, 7 Jun 2022 04:17:44 GMT, Ioi Lam  wrote:

> > We should try to consolidate these test cases to improve maintainability.
> 
> I filed [JDK-8287185](https://bugs.openjdk.org/browse/JDK-8287185)

Agreed. Thanks for the review @iklam

-

PR: https://git.openjdk.java.net/jdk/pull/8993


Re: RFR: 8287663 Add a regression test for JDK-8287073

2022-06-06 Thread Ioi Lam
On Mon, 6 Jun 2022 23:07:06 GMT, Ioi Lam  wrote:

> We should try to consolidate these test cases to improve maintainability.

I filed [JDK-8287185](https://bugs.openjdk.org/browse/JDK-8287185)

-

PR: https://git.openjdk.java.net/jdk/pull/8993


Re: RFR: 8287663 Add a regression test for JDK-8287073

2022-06-06 Thread Ioi Lam
On Thu, 2 Jun 2022 14:32:28 GMT, Severin Gehwolf  wrote:

> This adds a regression test for a recent fix (JDK-8287073). I've restructured 
> the linux specific JDK code to call a separate static function to enable this 
> test. It'll help future tests too.
> 
> Testing:
> - [x] Container tests continue to pass + GHA
> - [x] New regression test fails prior the code fix of JDK-8287073 and passes 
> with it

Not specific to this PR, but we have a general problem with lots of duplication 
between these two files. E.g.,


https://github.com/openjdk/jdk/blob/a50b06e85124f61b5133189a2a2e461753d5d9e7/test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java#L132-L143

https://github.com/openjdk/jdk/blob/a50b06e85124f61b5133189a2a2e461753d5d9e7/test/jdk/jdk/internal/platform/cgroup/TestCgroupSubsystemFactory.java#L130-L143

We should try to consolidate these test cases to improve maintainability.

-

PR: https://git.openjdk.java.net/jdk/pull/8993


Re: RFR: 8287663 Add a regression test for JDK-8287073

2022-06-06 Thread Ioi Lam
On Thu, 2 Jun 2022 14:32:28 GMT, Severin Gehwolf  wrote:

> This adds a regression test for a recent fix (JDK-8287073). I've restructured 
> the linux specific JDK code to call a separate static function to enable this 
> test. It'll help future tests too.
> 
> Testing:
> - [x] Container tests continue to pass + GHA
> - [x] New regression test fails prior the code fix of JDK-8287073 and passes 
> with it

LGTM.

-

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8993


Re: RFR: 8287663 Add a regression test for JDK-8287073

2022-06-02 Thread Maxim Kartashev
On Thu, 2 Jun 2022 14:32:28 GMT, Severin Gehwolf  wrote:

> This adds a regression test for a recent fix (JDK-8287073). I've restructured 
> the linux specific JDK code to call a separate static function to enable this 
> test. It'll help future tests too.
> 
> Testing:
> - [x] Container tests continue to pass + GHA
> - [x] New regression test fails prior the code fix of JDK-8287073 and passes 
> with it

@jerboaa Thanks for taking care of the test! I'm not a reviewer, but FWIW the 
test looks good to me.

-

PR: https://git.openjdk.java.net/jdk/pull/8993


RFR: 8287663 Add a regression test for JDK-8287073

2022-06-02 Thread Severin Gehwolf
This adds a regression test for a recent fix (JDK-8287073). I've restructured 
the linux specific JDK code to call a separate static function to enable this 
test. It'll help future tests too.

Testing:
- [x] Container tests continue to pass + GHA
- [x] New regression test fails prior the code fix of JDK-8287073 and passes 
with it

-

Commit messages:
 - 8287663 Add a regression test for JDK-8287073

Changes: https://git.openjdk.java.net/jdk/pull/8993/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8993=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8287663
  Stats: 36 lines in 2 files changed: 35 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8993.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8993/head:pull/8993

PR: https://git.openjdk.java.net/jdk/pull/8993