Re: RFR: JDK-8235767: Compilation failure caused by JDK-8212780: Packaging Tool Implementation

2019-12-11 Thread Alexey Semenyuk 

Looks good.

- Alexey

On 12/11/2019 10:42 AM, Andy Herrick wrote:

The revised webrev at [3] is confirmed by the submitter to fix the build.

please review

/Andy

[3] http://cr.openjdk.java.net/~herrick/8235767/webrev.02/

On 12/11/2019 9:49 AM, Andy Herrick wrote:

Please review simple jpackage fix for issue [1] at [2]

[1] https://bugs.openjdk.java.net/browse/JDK-8235767

[2] http://cr.openjdk.java.net/~herrick/8235767/webrev.01/

/Andy

Re: RFR: JDK-8235767: Compilation failure caused by JDK-8212780: Packaging Tool Implementation

2019-12-11 Thread Roman Kennke 
That fix looks good to me.

Thanks!
Roman

> The revised webrev at [3] is confirmed by the submitter to fix the build.
> 
> please review
> 
> /Andy
> 
> [3] http://cr.openjdk.java.net/~herrick/8235767/webrev.02/
> 
> On 12/11/2019 9:49 AM, Andy Herrick wrote:
>> Please review simple jpackage fix for issue [1] at [2]
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8235767
>>
>> [2] http://cr.openjdk.java.net/~herrick/8235767/webrev.01/
>>
>> /Andy
>>
>

RFR: JDK-8235767: Compilation failure caused by JDK-8212780: Packaging Tool Implementation

2019-12-11 Thread Andy Herrick 

Please review simple jpackage fix for issue [1] at [2]

[1] https://bugs.openjdk.java.net/browse/JDK-8235767

[2] http://cr.openjdk.java.net/~herrick/8235767/webrev.01/

/Andy