Re: RFR JDK-8167957: Remove FilePermission from default policy for jdk.charsets module

2016-10-13 Thread Mandy Chung
Thumbs up as long as the tests well cover the cases. Mandy > On Oct 13, 2016, at 2:19 PM, Xueming Shen wrote: > > Yes, there are couple test cases in the cs unit/regression tests running > under security manager > when testing. > > sherman > > On 10/13/2016 02:13 PM, Mandy Chung wrote: >>> O

Re: RFR JDK-8167957: Remove FilePermission from default policy for jdk.charsets module

2016-10-13 Thread Xueming Shen
Yes, there are couple test cases in the cs unit/regression tests running under security manager when testing. sherman On 10/13/2016 02:13 PM, Mandy Chung wrote: On Oct 13, 2016, at 2:03 PM, Xueming Shen wrote: Hi Please help review the change for JDK-8167957 issue: https://bugs.openjdk.ja

Re: RFR JDK-8167957: Remove FilePermission from default policy for jdk.charsets module

2016-10-13 Thread Mandy Chung
> On Oct 13, 2016, at 2:03 PM, Xueming Shen wrote: > > Hi > > Please help review the change for JDK-8167957 > > issue: https://bugs.openjdk.java.net/browse/JDK-8167957 > webrev: http://cr.openjdk.java.net/~sherman/8167957/webrev The change looks fine. Is there any existing test running with

RFR JDK-8167957: Remove FilePermission from default policy for jdk.charsets module

2016-10-13 Thread Xueming Shen
Hi Please help review the change for JDK-8167957 issue: https://bugs.openjdk.java.net/browse/JDK-8167957 webrev: http://cr.openjdk.java.net/~sherman/8167957/webrev There have been changes in jdk.charsets implementation to move pieces around for jigsaw. It appears the latest implementation does