Re: RFR JDK-8215300: additional changes to constants API

2018-12-13 Thread joe darcy
After the fact; looks good. Thanks, -Joe On 12/13/2018 7:17 AM, Brian Goetz wrote: +1 from me. Appears that it covers all the issues that were raised in the CSR and by JCK since integration. On Dec 13, 2018, at 10:14 AM, Vicente Romero wrote: Hi all, I have provided another iteration

Re: RFR JDK-8215300: additional changes to constants API

2018-12-13 Thread Brian Goetz
+1 from me. Appears that it covers all the issues that were raised in the CSR and by JCK since integration. > On Dec 13, 2018, at 10:14 AM, Vicente Romero > wrote: > > Hi all, > > I have provided another iteration to the webrev at [1]. This one includes > additional changes to make sure

Re: RFR JDK-8215300: additional changes to constants API

2018-12-13 Thread Vicente Romero
Hi all, I have provided another iteration to the webrev at [1]. This one includes additional changes to make sure that no array descriptor with more than 255 dimensions is created. Thanks, Vicente http://cr.openjdk.java.net/~vromero/8215300/webrev.01/ On 12/12/18 12:02 PM, Vicente Romero

RFR JDK-8215300: additional changes to constants API

2018-12-12 Thread Vicente Romero
Hi, Please review some final changes to the constants API. The changes should make the API clearer and more precise and were recommended in the CSR [3] Thanks, Vicente [1] (jira issue) https://bugs.openjdk.java.net/browse/JDK-8215300 [2] (webrev)