Re: [11] RFR: (JAXP) 8038043: Xerces Update: XInclude update

Looks good. Thanks! Best, Joe On 2/26/2018 7:34 AM, Aleks Efimov wrote: Hi Joe, Thank you for the review. I've updated XIncludeHandler and XIncludeTextReader files per your suggestions. XIncludeTextReader:191 line is still shown in Sdiffs as one line, but patch contains correct change that

Re: [11] RFR: (JAXP) 8038043: Xerces Update: XInclude update

Hi Joe, Thank you for the review. I've updated XIncludeHandler and XIncludeTextReader files per your suggestions. XIncludeTextReader:191 line is still shown in Sdiffs as one line, but patch contains correct change that splits it. New webrev: http://cr.openjdk.java.net/~aefimov/8038043/11/01

Re: [11] RFR: (JAXP) 8038043: Xerces Update: XInclude update

Hi Aleksei, Thanks for taking the time to work on this! Looks good overall. XIncludeHandler: setupCurrentBaseURI method can be private. XIncludeTextReader: there's a very long line at 191. It would be good to fix it so that Sdiffs looks better the next time. As for the tests, I'm fine with