Re: [11] RFR: 8191410 : Unicode 10.0.0

2018-03-28 Thread Ivan Gerasimov
Thanks Rachna! On 3/13/18 2:28 AM, Rachna Goel wrote: Hi Roger, Ivan, There is no change in algorithm as such but there has been mainly stability improvements, defects fixed, performance enhancements. e.g Updated header check, version and loading for latest binary files, Simple case

Re: [11] RFR: 8191410 : Unicode 10.0.0

2018-03-19 Thread Roger Riggs
Hi Rachna, Thanks for the updates; looks good, Roger On 3/13/2018 5:28 AM, Rachna Goel wrote: Hi Roger, Ivan, There is no change in algorithm as such but there has been mainly stability improvements, defects fixed, performance enhancements. e.g Updated header check, version and loading

Re: [11] RFR: 8191410 : Unicode 10.0.0

2018-03-19 Thread Naoto Sato
+1 Naoto On 3/19/18 1:12 PM, Roger Riggs wrote: Hi Rachna, Thanks for the updates; looks good, Roger On 3/13/2018 5:28 AM, Rachna Goel wrote: Hi Roger, Ivan, There is no change in algorithm as such but there has been mainly stability improvements, defects fixed, performance

Re: [11] RFR: 8191410 : Unicode 10.0.0

2018-03-13 Thread Rachna Goel
Hi Roger, Ivan, There is no change in algorithm as such but there has been mainly stability improvements, defects fixed, performance enhancements. e.g Updated header check, version and loading for latest binary files, Simple case mappings will be more efficient as unnecessary checking has

Re: [11] RFR: 8191410 : Unicode 10.0.0

2018-03-08 Thread Ivan Gerasimov
Hi Rachna! Just minor comments: You may want to update the initial capacity for the HashMaps: 1) private static Map map = new HashMap<>((int)(638 / 0.75f + 1.0f)); (the number 638 was determined as `cat Character.java | grep -A 2 'new

Re: [11] RFR: 8191410 : Unicode 10.0.0

2018-03-08 Thread Roger Riggs
Hi Rachna, sun/text/normalizer/NormalizerImpl.java: Is there a higher level description of the algorithmic changes? 102-105:   These look like accidental changes: the space should not be removed and the trailing "{" doesn't make sense in a comment. Regards, Roger On 3/8/2018 6:56 AM,