Re: [12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

2018-10-18 Thread Chris Yin
Thank you, Roger Chris > On 19 Oct 2018, at 2:56 AM, Roger Riggs wrote: > > Hi Chris, > > Looks ok. > > Roger > > > On 08/20/2018 03:24 AM, vyom tewari wrote: >> Hi Chris, >> >> Latest webrev(.02) looks good to me. One minor comment i will suggest you to >> expand "setContext" as you did

Re: [12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

2018-10-18 Thread Roger Riggs
Hi Chris, Looks ok. Roger On 08/20/2018 03:24 AM, vyom tewari wrote: Hi Chris, Latest webrev(.02) looks good to me. One minor comment i will suggest you to  expand "setContext" as you did for other JNDI tests. Thanks, Vyom On Friday 10 August 2018 02:34 PM, Chris Yin wrote: Sorry... an

Re: [12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

2018-08-22 Thread Chris Yin
Thank you, Vyom Regards, Chris > On 20 Aug 2018, at 3:24 PM, vyom tewari wrote: > > Hi Chris, > > Latest webrev(.02) looks good to me. One minor comment i will suggest you to > expand "setContext" as you did for other JNDI tests. > > Thanks, > > Vyom > > > On Friday 10 August 2018 02:34

Re: [12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

2018-08-20 Thread vyom tewari
Hi Chris, Latest webrev(.02) looks good to me. One minor comment i will suggest you to  expand "setContext" as you did for other JNDI tests. Thanks, Vyom On Friday 10 August 2018 02:34 PM, Chris Yin wrote: Sorry... another minor revision to handle @Override line and imports place, new web

Re: [12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

2018-08-10 Thread Chris Yin
Sorry... another minor revision to handle @Override line and imports place, new webrev as below, thanks http://cr.openjdk.java.net/~xyin/8208542/webrev.02/ Regards, Chris > On 8 Aug 2018, at 2:51 PM, Chris Yin wrote: > > Minor revision to address javadoc, initContext() expansion, vararg etc.

Re: [12] RFR 8208542: Add 4 JNDI tests to com/sun/jndi/dns/ListTests/

2018-08-07 Thread Chris Yin
Minor revision to address javadoc, initContext() expansion, vararg etc. webrev as below, thanks http://cr.openjdk.java.net/~xyin/8208542/webrev.01/ Regards, Chris > On 31 Jul 2018, at 2:39 PM, Chris Yin wrote: > > Please review the changes to add 4 JNDI tests to com/sun/jndi/dns/ListTests/