Re: [PATCH] Optimization of AbstractStringBuilder.ensureCapacityInternal()

2018-02-23 Thread Roman Leventov
Hi Claes, indeed, seems that this change breaks the zeroing optimization, so ensureCapacityInternal() becomes slower when the char count is comparable with the array length. Thanks. On 22 February 2018 at 18:35, Claes Redestad wrote: > Hi, > > interesting - do you have any numbers showing a bene

Re: [PATCH] Optimization of AbstractStringBuilder.ensureCapacityInternal()

2018-02-22 Thread Claes Redestad
Hi, interesting - do you have any numbers showing a benefit from doing this (on various sets of input)? My concerns are that count might typically be close enough to value.length to make the difference small in practice, and that there are some (fragile) JIT optimizations to try and avoid zeroin

Re: [PATCH] Optimization of AbstractStringBuilder.ensureCapacityInternal()

2018-02-22 Thread Roman Leventov
Similar optimizations are also possible in ArrayList and Vector. On 22 February 2018 at 17:51, Roman Leventov wrote: > AbstractStringBuilder.ensureCapacityInternal() doesn't need to copy the > whole underlying array, only the part until the current count. > > diff --git a/src/java.base/share/cla