Re: [jdk17] RFR: JDK-8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component class [v2]
On Fri, 25 Jun 2021 18:46:30 GMT, Mandy Chung wrote: >> `Lookup::accessClass` should determine the accessibility of the element >> type. An array class is accessible if and only if its element type is >> accessible. >> >> This also fixes a spec bug to document `@throws NullPointerException` if the >> argument is null. >> >> Please review the CSR: >> https://bugs.openjdk.java.net/browse/JDK-8269312 > > Mandy Chung has updated the pull request incrementally with one additional > commit since the last revision: > > remove extra import I also notice that `t8150782` outliner. It'd actually prefer to remove the directory `t8150782` or place the tests in a directory name with descriptive name. That can be cleaned up as a separate issue. - PR: https://git.openjdk.java.net/jdk17/pull/137
Re: [jdk17] RFR: JDK-8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component class [v2]
On Fri, 25 Jun 2021 18:46:30 GMT, Mandy Chung wrote: >> `Lookup::accessClass` should determine the accessibility of the element >> type. An array class is accessible if and only if its element type is >> accessible. >> >> This also fixes a spec bug to document `@throws NullPointerException` if the >> argument is null. >> >> Please review the CSR: >> https://bugs.openjdk.java.net/browse/JDK-8269312 > > Mandy Chung has updated the pull request incrementally with one additional > commit since the last revision: > > remove extra import Looks okay. In passing I think t8150782 is the only test directory using that naming convention. There are several tests using in the directory name. - Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/137
Re: [jdk17] RFR: JDK-8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component class [v2]
> `Lookup::accessClass` should determine the accessibility of the element type. > An array class is accessible if and only if its element type is accessible. > > This also fixes a spec bug to document `@throws NullPointerException` if the > argument is null. > > Please review the CSR: > https://bugs.openjdk.java.net/browse/JDK-8269312 Mandy Chung has updated the pull request incrementally with one additional commit since the last revision: remove extra import - Changes: - all: https://git.openjdk.java.net/jdk17/pull/137/files - new: https://git.openjdk.java.net/jdk17/pull/137/files/96da75be..0579507f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk17=137=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk17=137=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.java.net/jdk17/pull/137.diff Fetch: git fetch https://git.openjdk.java.net/jdk17 pull/137/head:pull/137 PR: https://git.openjdk.java.net/jdk17/pull/137
Re: [jdk17] RFR: JDK-8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component class
On Fri, 25 Jun 2021 08:44:54 GMT, Chris Hegarty wrote: >> `Lookup::accessClass` should determine the accessibility of the element >> type. An array class is accessible if and only if its element type is >> accessible. >> >> This also fixes a spec bug to document `@throws NullPointerException` if the >> argument is null. >> >> Please review the CSR: >> https://bugs.openjdk.java.net/browse/JDK-8269312 > > test/jdk/java/lang/invoke/t8150782/TestFindClass.java line 42: > >> 40: >> 41: import org.testng.annotations.*; >> 42: import p.Foo; > > maybe a stray import? Yup. Will remove it. - PR: https://git.openjdk.java.net/jdk17/pull/137
Re: [jdk17] RFR: JDK-8266269: Lookup::accessClass fails with IAE when accessing an arrayClass with a protected inner class as component class
On Thu, 24 Jun 2021 18:42:23 GMT, Mandy Chung wrote: > `Lookup::accessClass` should determine the accessibility of the element type. > An array class is accessible if and only if its element type is accessible. > > This also fixes a spec bug to document `@throws NullPointerException` if the > argument is null. > > Please review the CSR: > https://bugs.openjdk.java.net/browse/JDK-8269312 Marked as reviewed by chegar (Reviewer). test/jdk/java/lang/invoke/t8150782/TestFindClass.java line 42: > 40: > 41: import org.testng.annotations.*; > 42: import p.Foo; maybe a stray import? - PR: https://git.openjdk.java.net/jdk17/pull/137
