Re: 8032456: vm/jni/Miscellaneous/misc001/misc00101m1/misc00101m1.html failing on OS X

2014-01-24 Thread Staffan Larsen
Looks good! :-) Thanks, /Staffan On 24 jan 2014, at 12:00, Alan Bateman alan.bate...@oracle.com wrote: I need a reviewer to fix an issue with the changes in JDK 8 to support statically linked JNI libraries. The issue arises with tests that have both JNI_OnLoad and JNI_OnLoad_libname

Re: 8032456: vm/jni/Miscellaneous/misc001/misc00101m1/misc00101m1.html failing on OS X

2014-01-24 Thread Chris Hegarty
The change looks good to me Alan. -Chris. On 24/01/14 11:00, Alan Bateman wrote: I need a reviewer to fix an issue with the changes in JDK 8 to support statically linked JNI libraries. The issue arises with tests that have both JNI_OnLoad and JNI_OnLoad_libname functions defined, and code

Re: 8032456: vm/jni/Miscellaneous/misc001/misc00101m1/misc00101m1.html failing on OS X

2014-01-24 Thread Paul Sandoz
On Jan 24, 2014, at 12:00 PM, Alan Bateman alan.bate...@oracle.com wrote: I need a reviewer to fix an issue with the changes in JDK 8 to support statically linked JNI libraries. The issue arises with tests that have both JNI_OnLoad and JNI_OnLoad_libname functions defined, and code

Re: 8032456: vm/jni/Miscellaneous/misc001/misc00101m1/misc00101m1.html failing on OS X

2014-01-24 Thread Alan Bateman
On 24/01/2014 11:19, Paul Sandoz wrote: : So more precisely that is RTLD_LAZY | RTLD_FIRST ? Either will do, I went for RTLD_FIRST to be consistent with the hotspot change. -Alan

Re: 8032456: vm/jni/Miscellaneous/misc001/misc00101m1/misc00101m1.html failing on OS X

2014-01-24 Thread Mandy Chung
This patch looks fine. For JDK 9, it might be worth considering using the common code via JVM functions to replace getProcessHandle, JDK_FindJvmEntry, JDK_InitJvmEntry for native symbol lookup (jni_util.h and jdk_util.h) Mandy On 1/24/2014 3:00 AM, Alan Bateman wrote: I need a reviewer to