Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-15 Thread sangheon.kim 

Hi Thomas,

On 02/15/2018 03:32 AM, Thomas Schatzl wrote:

Hi,

On Wed, 2018-02-14 at 13:45 -0800, sangheon.kim wrote:

Hi all,

Could I have some reviews for CMM removal?
This is closed CR but some public codes also need small
modifications.
This CR is for removing stuff related to an Oracle JDK
module/package.
Changes are just removing CMM from lists or in a test to skip the
testing logic.

CR: https://bugs.openjdk.java.net/browse/JDK-8193909
Webrev: http://cr.openjdk.java.net/~sangheki/8193909/webrev.0
Testing: hs-tier1~5, jdk1~3, open/test/jdk:jdk_core


   looks good.

Thank you for your review!

Sangheon




Thomas

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-15 Thread Thomas Schatzl 
Hi,

On Wed, 2018-02-14 at 13:45 -0800, sangheon.kim wrote:
> Hi all,
> 
> Could I have some reviews for CMM removal?
> This is closed CR but some public codes also need small
> modifications. 
> This CR is for removing stuff related to an Oracle JDK
> module/package.
> Changes are just removing CMM from lists or in a test to skip the 
> testing logic.
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8193909
> Webrev: http://cr.openjdk.java.net/~sangheki/8193909/webrev.0
> Testing: hs-tier1~5, jdk1~3, open/test/jdk:jdk_core
> 

  looks good.

Thomas

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-14 Thread sangheon.kim 

Hi Mandy,

Thank you for the review!

Sangheon


On 02/14/2018 03:45 PM, mandy chung wrote:

+1

Mandy

On 2/14/18 1:45 PM, sangheon.kim wrote:

Hi all,

Could I have some reviews for CMM removal?
This is closed CR but some public codes also need small 
modifications. This CR is for removing stuff related to an Oracle JDK 
module/package.
Changes are just removing CMM from lists or in a test to skip the 
testing logic.


CR: https://bugs.openjdk.java.net/browse/JDK-8193909
Webrev: http://cr.openjdk.java.net/~sangheki/8193909/webrev.0
Testing: hs-tier1~5, jdk1~3, open/test/jdk:jdk_core

Thanks,
Sangheon

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-14 Thread mandy chung 

+1

Mandy

On 2/14/18 1:45 PM, sangheon.kim wrote:

Hi all,

Could I have some reviews for CMM removal?
This is closed CR but some public codes also need small modifications. 
This CR is for removing stuff related to an Oracle JDK module/package.
Changes are just removing CMM from lists or in a test to skip the 
testing logic.


CR: https://bugs.openjdk.java.net/browse/JDK-8193909
Webrev: http://cr.openjdk.java.net/~sangheki/8193909/webrev.0
Testing: hs-tier1~5, jdk1~3, open/test/jdk:jdk_core

Thanks,
Sangheon

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-14 Thread sangheon.kim 

Hi David and Jesper,

Thank you for the review.

Sangheon


On 02/14/2018 02:53 PM, jesper.wilhelms...@oracle.com wrote:

Looks good!
/Jesper


On 14 Feb 2018, at 22:45, sangheon.kim  wrote:

Hi all,

Could I have some reviews for CMM removal?
This is closed CR but some public codes also need small modifications. This CR 
is for removing stuff related to an Oracle JDK module/package.
Changes are just removing CMM from lists or in a test to skip the testing logic.

CR: https://bugs.openjdk.java.net/browse/JDK-8193909
Webrev: http://cr.openjdk.java.net/~sangheki/8193909/webrev.0
Testing: hs-tier1~5, jdk1~3, open/test/jdk:jdk_core

Thanks,
Sangheon

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-14 Thread jesper . wilhelmsson 
Looks good!
/Jesper

> On 14 Feb 2018, at 22:45, sangheon.kim  wrote:
> 
> Hi all,
> 
> Could I have some reviews for CMM removal?
> This is closed CR but some public codes also need small modifications. This 
> CR is for removing stuff related to an Oracle JDK module/package.
> Changes are just removing CMM from lists or in a test to skip the testing 
> logic.
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8193909
> Webrev: http://cr.openjdk.java.net/~sangheki/8193909/webrev.0
> Testing: hs-tier1~5, jdk1~3, open/test/jdk:jdk_core
> 
> Thanks,
> Sangheon
>

Re: RFR(xs): 8193909: Obsolete(remove) Co-operative Memory Management (CMM)

2018-02-14 Thread David Holmes 

That all seems trivially fine.

Thanks,
David

On 15/02/2018 7:45 AM, sangheon.kim wrote:

Hi all,

Could I have some reviews for CMM removal?
This is closed CR but some public codes also need small modifications. 
This CR is for removing stuff related to an Oracle JDK module/package.
Changes are just removing CMM from lists or in a test to skip the 
testing logic.


CR: https://bugs.openjdk.java.net/browse/JDK-8193909
Webrev: http://cr.openjdk.java.net/~sangheki/8193909/webrev.0
Testing: hs-tier1~5, jdk1~3, open/test/jdk:jdk_core

Thanks,
Sangheon