eyarath/8184693/webrev.05/ .
Regards
Vivek
-Original Message-
From: Stuart Marks
Sent: Wednesday, April 18, 2018 8:56 AM
To: Vivek Theeyarath
Cc: core-libs-dev ; Paul Sandoz
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
Hi Vivek,
Thanks for the update. In the test files, pl
Vivek Theeyarath
Cc: core-libs-dev ; Paul Sandoz
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
Hi Vivek,
Thanks for the update. In the test files, please remove the unnecessary imports
of List and the various Predicate types. In most cases it's not a problem to
have unnecessary
t; Regards
> Vivek
>
> -Original Message-
> From: Stuart Marks
> Sent: Tuesday, April 17, 2018 5:11 AM
> To: Vivek Theeyarath
> Cc: core-libs-dev ; Paul Sandoz
>
> Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
>
> Hi Vivek,
>
> Plea
riginal Message-
From: Stuart Marks
Sent: Tuesday, April 17, 2018 5:11 AM
To: Vivek Theeyarath
Cc: core-libs-dev ; Paul Sandoz
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
Hi Vivek,
Please add "@since 11" tags to the doc comments of the four Optional*.isEmpty()
methods.
Reg
arath/8184693/webrev.01/
>
> This looks ok to me.
>
> For consistency, can you please update the copyright header year range in
> OptionalInt.
>
> -Chris.
>
>> Regards
>> Vivek
>> -Original Message-
>> From: Vivek Theeyarath
>> Sent
/webrev.02/ .
Here is the csr which I have raised for this change
https://bugs.openjdk.java.net/browse/JDK-8201606
Regards
Vivek
-Original Message-
From: Chris Hegarty
Sent: Sunday, April 15, 2018 6:48 PM
To: Vivek Theeyarath
Cc: Remi Forax ; core-libs-dev
Subject: Re: RFR: 8184693: (
, 2018 6:48 PM
To: Vivek Theeyarath
Cc: Remi Forax ; core-libs-dev
Subject: Re: RFR: 8184693: (opt) add Optional.isEmpty
> On 15 Apr 2018, at 11:25, Vivek Theeyarath
> wrote:
>
> Hi All,
>Please review http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.01/
This looks
t; Regards
> Vivek
> -Original Message-
> From: Vivek Theeyarath
> Sent: Saturday, April 14, 2018 6:24 PM
> To: Remi Forax
> Cc: core-libs-dev
> Subject: RE: RFR: 8184693: (opt) add Optional.isEmpty
>
> I missed that Remi. Thanks for pointing it out. Will addres
uot;
>
> Envoyé: Dimanche 15 Avril 2018 12:25:09
> Objet: RE: RFR: 8184693: (opt) add Optional.isEmpty
> Hi All,
> Please review http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.01/
>
> Regards
> Vivek
> -Original Message-
> From: Vivek Theeyara
Hi All,
Please review
http://cr.openjdk.java.net/~vtheeyarath/8184693/webrev.01/
Regards
Vivek
-Original Message-
From: Vivek Theeyarath
Sent: Saturday, April 14, 2018 6:24 PM
To: Remi Forax
Cc: core-libs-dev
Subject: RE: RFR: 8184693: (opt) add Optional.isEmpty
I missed
I missed that Remi. Thanks for pointing it out. Will address those and get back.
Regards
Vivek
-Original Message-
From: Remi Forax [mailto:fo...@univ-mlv.fr]
Sent: Saturday, April 14, 2018 2:58 PM
To: Vivek Theeyarath
Cc: core-libs-dev
Subject: Re: RFR: 8184693: (opt) add
Hi Vivek,
the parenthesis around the lambdas in Basic.java are unnecessary
Predicate isPositiveNumber = (x -> x > 0);
vs
Predicate isPositiveNumber = x -> x > 0;
the same remark for isNegativeNumber.
cheers,
Rémi
- Mail original -
> De: "Vivek Theeyarath"
> À: "core-libs-dev"
> E
Hi Vivek,
OptionalInt, OptionalLong and OptionalDouble should be changed too.
Rémi
- Mail original -
> De: "Vivek Theeyarath"
> À: "core-libs-dev"
> Envoyé: Samedi 14 Avril 2018 08:22:50
> Objet: RFR: 8184693: (opt) add Optional.isEmpty
> Hi All,
>
> Please review.
>
>
13 matches
Mail list logo
