Re: RFR: 8196988 (Resolve disabled warnings for libjimage)

2018-06-17 Thread Srinivas Dama
ct: Re: RFR: 8196988 (Resolve disabled warnings for libjimage) Looks ok. Including Jim in case he is not listening in… I am guessing the comment selectively disables the warning in this code (rather than using a diagnostic pragma). Thanks, Paul. > On Jun 7, 2018, at 11:17 PM, Srinivas Da

Re: RFR: 8196988 (Resolve disabled warnings for libjimage)

2018-06-12 Thread mandy chung
-dev@openjdk.java.net Subject: Re: RFR: 8196988 (Resolve disabled warnings for libjimage) Hi, Please review http://cr.openjdk.java.net/~sdama/8196988/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8196988 Note: Modified earlier fix to handle warning messages specific to libjimage only

Re: RFR: 8196988 (Resolve disabled warnings for libjimage)

2018-06-12 Thread Paul Sandoz
Looks ok. Including Jim in case he is not listening in… I am guessing the comment selectively disables the warning in this code (rather than using a diagnostic pragma). Thanks, Paul. > On Jun 7, 2018, at 11:17 PM, Srinivas Dama wrote: > > Hi, > > Please review

RE: RFR: 8196988 (Resolve disabled warnings for libjimage)

2018-06-11 Thread Srinivas Dama
Gentle reminder. May I have review for the below changeset. Regards, Srinivas -Original Message- From: Srinivas Dama Sent: Friday, June 08, 2018 11:47 AM To: core-libs-dev@openjdk.java.net Subject: Re: RFR: 8196988 (Resolve disabled warnings for libjimage) Hi, Please review http

Re: RFR: 8196988 (Resolve disabled warnings for libjimage)

2018-06-08 Thread Srinivas Dama
Hi, Please review http://cr.openjdk.java.net/~sdama/8196988/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8196988 Note: Modified earlier fix to handle warning messages specific to libjimage only. Regards, Srinivas - Original Message - From: srinivas.d...@oracle.com To: