Re: RFR: 8238373: Punctuation should be same in jlink help usage on Japanese language [v2]
On Mon, 9 May 2022 06:38:29 GMT, KIRIYAMA Takuya wrote: >> When showing help for the jlink command in a Japanese locale, delimiters of >> option's aliases are a mixture of "," and \u3001. Delimiter should be >> unified to ",". >> As the same, there is a inconsistency of delimiters in the jar command help >> in a Japanese locale, and "," should be used. >> Similarly, the javap command help uses space as delimiters other than the >> module option in all locales. This inconsistency should also be corrected. >> >> Would you please review this fix? > > KIRIYAMA Takuya has updated the pull request incrementally with one > additional commit since the last revision: > > 8238373: Punctuation should be same in jlink help usage on Japanese language I think it's ready for you to integrate. I can sponsor your changes. - PR: https://git.openjdk.java.net/jdk/pull/8417
Re: RFR: 8238373: Punctuation should be same in jlink help usage on Japanese language [v2]
On Wed, 27 Apr 2022 16:42:23 GMT, Naoto Sato wrote: > Looks fine to me. Nit: please modify the copyright years for `javap` > properties files, as you modified the base (`javap.properties`) file. I’m sorry for the late reply. Thank you for your advice. I modified the copyright years for all files. - PR: https://git.openjdk.java.net/jdk/pull/8417
Re: RFR: 8238373: Punctuation should be same in jlink help usage on Japanese language [v2]
> When showing help for the jlink command in a Japanese locale, delimiters of > option's aliases are a mixture of "," and \u3001. Delimiter should be unified > to ",". > As the same, there is a inconsistency of delimiters in the jar command help > in a Japanese locale, and "," should be used. > Similarly, the javap command help uses space as delimiters other than the > module option in all locales. This inconsistency should also be corrected. > > Would you please review this fix? KIRIYAMA Takuya has updated the pull request incrementally with one additional commit since the last revision: 8238373: Punctuation should be same in jlink help usage on Japanese language - Changes: - all: https://git.openjdk.java.net/jdk/pull/8417/files - new: https://git.openjdk.java.net/jdk/pull/8417/files/5163b9df..c881ec75 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8417=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8417=00-01 Stats: 6 lines in 6 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/jdk/pull/8417.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8417/head:pull/8417 PR: https://git.openjdk.java.net/jdk/pull/8417
