Re: RFR: 8277659: [TESTBUG] Microbenchmark ThreadOnSpinWaitProducerConsumer.java hangs

2021-11-25 Thread Nick Gasson
On Thu, 25 Nov 2021 11:57:52 GMT, Stuart Monteith  wrote:

> Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread 
> to finish before restarting trial method.

Marked as reviewed by ngasson (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/6560


Re: RFR: 8277659: [TESTBUG] Microbenchmark ThreadOnSpinWaitProducerConsumer.java hangs

2021-11-25 Thread Ningsheng Jian
On Thu, 25 Nov 2021 11:57:52 GMT, Stuart Monteith  wrote:

> Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread 
> to finish before restarting trial method.

Looks good to me.

-

Marked as reviewed by njian (Committer).

PR: https://git.openjdk.java.net/jdk/pull/6560


Re: RFR: 8277659: [TESTBUG] Microbenchmark ThreadOnSpinWaitProducerConsumer.java hangs

2021-11-25 Thread Stuart Monteith
On Thu, 25 Nov 2021 11:57:52 GMT, Stuart Monteith  wrote:

> Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread 
> to finish before restarting trial method.

@nick-arm @nsjian Could you review, push this please?

-

PR: https://git.openjdk.java.net/jdk/pull/6560


Re: RFR: 8277659: [TESTBUG] Microbenchmark ThreadOnSpinWaitProducerConsumer.java hangs

2021-11-25 Thread Evgeny Astigeevich
On Thu, 25 Nov 2021 11:57:52 GMT, Stuart Monteith  wrote:

> Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread 
> to finish before restarting trial method.

@stooart-mon Thank you for fixing the bug.
lgtm

-

Marked as reviewed by eas...@github.com (no known OpenJDK username).

PR: https://git.openjdk.java.net/jdk/pull/6560


Re: RFR: 8277659: [TESTBUG] Microbenchmark ThreadOnSpinWaitProducerConsumer.java hangs

2021-11-25 Thread Stuart Monteith
On Thu, 25 Nov 2021 11:57:52 GMT, Stuart Monteith  wrote:

> Fix java/lang/ThreadOnSpinWaitProducerConsumer by waiting for consumer thread 
> to finish before restarting trial method.

@eastig could you review this please?

-

PR: https://git.openjdk.java.net/jdk/pull/6560