Re: RFR: 8279047: Remove expired flags in JDK 20
On Sat, 11 Jun 2022 05:48:14 GMT, Alan Bateman wrote: >> Expired Flags in 20: >> >> - FilterSpuriousWakeups >> - MinInliningThreshold >> - PrefetchFieldsAhead >> >> No remaining usages in code or tests. >> >> - UseHeavyMonitors (expired in PRODUCT ONLY) >> >> As this flag now only exists for debug builds it has to be a "develop" flag >> rather than product. There are then changes to two tests that use this flag, >> so that they only run on a debug VM. >> >> - test/jdk/java/lang/Thread/virtual/HoldsLock.java >> >> The second @run that uses UseHeavyMonitors is moved to a second test segment >> that only applies to the debug VM. >> >> - test/jdk/java/util/concurrent/ConcurrentHashMap/MapLoops.java >> >> Change the test section that uses UseHeavyMonitors to only run on a debug VM >> and remove the IgnoreUnrecognizedOptions flag. Note that the existing test >> logic would run the same test twice on product builds. >> >> No documentation in the manpage exists for any of the newly expired flags. >> >> Obsoleted flags in 20: >> >> - ExtendedDTraceProbes >> >> Documented in manpage so moved from Deprecated section to Obsolete section. >> There is special handling for messages about use of this flag so that won't >> be updated until the flag is actually obsoleted (JDK-8279913). >> >> - UseContainerCpuShares >> - PreferContainerQuotaForCPUCount >> - AliasLevel >> >> Undocumented. >> >> Java manpage updates: >> - Updates Java version to 20 >> - Moved ExtendedDTraceProbe info as previously mentioned >> - Applied changes from the .1 file that had not been applied to the markdown >> source so that they were not lost (and note the .1 file was also missing >> changes from the markdown file that had not been propagated). >> - Removed an unrepresentable character (the section symbol) that was not >> being generated into either the html or nroff file correctly > > Marked as reviewed by alanb (Reviewer). Thanks for the review @AlanBateman ! - PR: https://git.openjdk.org/jdk/pull/9127
Re: RFR: 8279047: Remove expired flags in JDK 20
On Fri, 10 Jun 2022 13:23:51 GMT, David Holmes wrote:
> Expired Flags in 20:
>
> - FilterSpuriousWakeups
> - MinInliningThreshold
> - PrefetchFieldsAhead
>
> No remaining usages in code or tests.
>
> - UseHeavyMonitors (expired in PRODUCT ONLY)
>
> As this flag now only exists for debug builds it has to be a "develop" flag
> rather than product. There are then changes to two tests that use this flag,
> so that they only run on a debug VM.
>
> - test/jdk/java/lang/Thread/virtual/HoldsLock.java
>
> The second @run that uses UseHeavyMonitors is moved to a second test segment
> that only applies to the debug VM.
>
> - test/jdk/java/util/concurrent/ConcurrentHashMap/MapLoops.java
>
> Change the test section that uses UseHeavyMonitors to only run on a debug VM
> and remove the IgnoreUnrecognizedOptions flag. Note that the existing test
> logic would run the same test twice on product builds.
>
> No documentation in the manpage exists for any of the newly expired flags.
>
> Obsoleted flags in 20:
>
> - ExtendedDTraceProbes
>
> Documented in manpage so moved from Deprecated section to Obsolete section.
> There is special handling for messages about use of this flag so that won't
> be updated until the flag is actually obsoleted (JDK-8279913).
>
> - UseContainerCpuShares
> - PreferContainerQuotaForCPUCount
> - AliasLevel
>
> Undocumented.
>
> Java manpage updates:
> - Updates Java version to 20
> - Moved ExtendedDTraceProbe info as previously mentioned
> - Applied changes from the .1 file that had not been applied to the markdown
> source so that they were not lost (and note the .1 file was also missing
> changes from the markdown file that had not been propagated).
> - Removed an unrepresentable character (the section symbol) that was not
> being generated into either the html or nroff file correctly
Marked as reviewed by alanb (Reviewer).
test/jdk/java/lang/Thread/virtual/HoldsLock.java line 39:
> 37: * @modules java.base/java.lang:+open
> 38: * @compile --enable-preview -source ${jdk.version} HoldsLock.java
> 39: * @run testng/othervm --enable-preview -XX:+UseHeavyMonitors HoldsLock
The test updates look okay, probably don't need to duplicate the summary tag
when it's unchanged but what you have is okay.
-
PR: https://git.openjdk.org/jdk/pull/9127
Re: RFR: 8279047: Remove expired flags in JDK 20
On Fri, 10 Jun 2022 15:57:40 GMT, Vladimir Kozlov wrote: >> Expired Flags in 20: >> >> - FilterSpuriousWakeups >> - MinInliningThreshold >> - PrefetchFieldsAhead >> >> No remaining usages in code or tests. >> >> - UseHeavyMonitors (expired in PRODUCT ONLY) >> >> As this flag now only exists for debug builds it has to be a "develop" flag >> rather than product. There are then changes to two tests that use this flag, >> so that they only run on a debug VM. >> >> - test/jdk/java/lang/Thread/virtual/HoldsLock.java >> >> The second @run that uses UseHeavyMonitors is moved to a second test segment >> that only applies to the debug VM. >> >> - test/jdk/java/util/concurrent/ConcurrentHashMap/MapLoops.java >> >> Change the test section that uses UseHeavyMonitors to only run on a debug VM >> and remove the IgnoreUnrecognizedOptions flag. Note that the existing test >> logic would run the same test twice on product builds. >> >> No documentation in the manpage exists for any of the newly expired flags. >> >> Obsoleted flags in 20: >> >> - ExtendedDTraceProbes >> >> Documented in manpage so moved from Deprecated section to Obsolete section. >> There is special handling for messages about use of this flag so that won't >> be updated until the flag is actually obsoleted (JDK-8279913). >> >> - UseContainerCpuShares >> - PreferContainerQuotaForCPUCount >> - AliasLevel >> >> Undocumented. >> >> Java manpage updates: >> - Updates Java version to 20 >> - Moved ExtendedDTraceProbe info as previously mentioned >> - Applied changes from the .1 file that had not been applied to the markdown >> source so that they were not lost (and note the .1 file was also missing >> changes from the markdown file that had not been propagated). >> - Removed an unrepresentable character (the section symbol) that was not >> being generated into either the html or nroff file correctly > > Looks good. Thanks for the reviews @vnkozlov and @kimbarrett ! - PR: https://git.openjdk.org/jdk/pull/9127
Re: RFR: 8279047: Remove expired flags in JDK 20
On Fri, 10 Jun 2022 13:23:51 GMT, David Holmes wrote: > Expired Flags in 20: > > - FilterSpuriousWakeups > - MinInliningThreshold > - PrefetchFieldsAhead > > No remaining usages in code or tests. > > - UseHeavyMonitors (expired in PRODUCT ONLY) > > As this flag now only exists for debug builds it has to be a "develop" flag > rather than product. There are then changes to two tests that use this flag, > so that they only run on a debug VM. > > - test/jdk/java/lang/Thread/virtual/HoldsLock.java > > The second @run that uses UseHeavyMonitors is moved to a second test segment > that only applies to the debug VM. > > - test/jdk/java/util/concurrent/ConcurrentHashMap/MapLoops.java > > Change the test section that uses UseHeavyMonitors to only run on a debug VM > and remove the IgnoreUnrecognizedOptions flag. Note that the existing test > logic would run the same test twice on product builds. > > No documentation in the manpage exists for any of the newly expired flags. > > Obsoleted flags in 20: > > - ExtendedDTraceProbes > > Documented in manpage so moved from Deprecated section to Obsolete section. > There is special handling for messages about use of this flag so that won't > be updated until the flag is actually obsoleted (JDK-8279913). > > - UseContainerCpuShares > - PreferContainerQuotaForCPUCount > - AliasLevel > > Undocumented. > > Java manpage updates: > - Updates Java version to 20 > - Moved ExtendedDTraceProbe info as previously mentioned > - Applied changes from the .1 file that had not been applied to the markdown > source so that they were not lost (and note the .1 file was also missing > changes from the markdown file that had not been propagated). > - Removed an unrepresentable character (the section symbol) that was not > being generated into either the html or nroff file correctly Looks good. - Marked as reviewed by kbarrett (Reviewer). PR: https://git.openjdk.org/jdk/pull/9127
Re: RFR: 8279047: Remove expired flags in JDK 20
On Fri, 10 Jun 2022 13:23:51 GMT, David Holmes wrote: > Expired Flags in 20: > > - FilterSpuriousWakeups > - MinInliningThreshold > - PrefetchFieldsAhead > > No remaining usages in code or tests. > > - UseHeavyMonitors (expired in PRODUCT ONLY) > > As this flag now only exists for debug builds it has to be a "develop" flag > rather than product. There are then changes to two tests that use this flag, > so that they only run on a debug VM. > > - test/jdk/java/lang/Thread/virtual/HoldsLock.java > > The second @run that uses UseHeavyMonitors is moved to a second test segment > that only applies to the debug VM. > > - test/jdk/java/util/concurrent/ConcurrentHashMap/MapLoops.java > > Change the test section that uses UseHeavyMonitors to only run on a debug VM > and remove the IgnoreUnrecognizedOptions flag. Note that the existing test > logic would run the same test twice on product builds. > > No documentation in the manpage exists for any of the newly expired flags. > > Obsoleted flags in 20: > > - ExtendedDTraceProbes > > Documented in manpage so moved from Deprecated section to Obsolete section. > There is special handling for messages about use of this flag so that won't > be updated until the flag is actually obsoleted (JDK-8279913). > > - UseContainerCpuShares > - PreferContainerQuotaForCPUCount > - AliasLevel > > Undocumented. > > Java manpage updates: > - Updates Java version to 20 > - Moved ExtendedDTraceProbe info as previously mentioned > - Applied changes from the .1 file that had not been applied to the markdown > source so that they were not lost (and note the .1 file was also missing > changes from the markdown file that had not been propagated). > - Removed an unrepresentable character (the section symbol) that was not > being generated into either the html or nroff file correctly Looks good. - Marked as reviewed by kvn (Reviewer). PR: https://git.openjdk.org/jdk/pull/9127
