Re: RFR: 8284638: store skip buffers in InputStream Object [v8]

2022-04-20 Thread XenoAmess 
On Wed, 20 Apr 2022 16:16:05 GMT, liach  wrote:

>> XenoAmess has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   remove useless skipBuffer
>
> src/java.base/share/classes/java/io/InputStream.java line 57:
> 
>> 55: private static final int MAX_SKIP_BUFFER_SIZE = 2048;
>> 56: 
>> 57: private static final int MIN_SKIP_BUFFER_SIZE = 128;
> 
> @jmehrens mentioned that this one can be removed as well since it's not used.

@jmehrens @liach you are correct. done.

-

PR: https://git.openjdk.java.net/jdk/pull/5872

Re: RFR: 8284638: store skip buffers in InputStream Object [v8]

2022-04-20 Thread liach 
On Wed, 20 Apr 2022 16:07:17 GMT, XenoAmess  wrote:

>> @jmehrens what about this then?
>> I think it safe now(actually this mechanism is learned from Reader)
>
> XenoAmess has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   remove useless skipBuffer

src/java.base/share/classes/java/io/InputStream.java line 57:

> 55: private static final int MAX_SKIP_BUFFER_SIZE = 2048;
> 56: 
> 57: private static final int MIN_SKIP_BUFFER_SIZE = 128;

@jmehrens mentioned that this one can be removed as well since it's not used.

-

PR: https://git.openjdk.java.net/jdk/pull/5872

Re: RFR: 8284638: store skip buffers in InputStream Object [v8]

2022-04-20 Thread XenoAmess 
> @jmehrens what about this then?
> I think it safe now(actually this mechanism is learned from Reader)

XenoAmess has updated the pull request incrementally with one additional commit 
since the last revision:

  remove useless skipBuffer

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5872/files
  - new: https://git.openjdk.java.net/jdk/pull/5872/files/9854f523..31652c3a

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=5872=07
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=5872=06-07

  Stats: 3 lines in 1 file changed: 0 ins; 3 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5872.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5872/head:pull/5872

PR: https://git.openjdk.java.net/jdk/pull/5872