Re: RFR: 8284942: Proxy building can just iterate superinterfaces once [v3]

2022-05-31 Thread liach
On Fri, 20 May 2022 00:10:01 GMT, Mandy Chung wrote: >> liach has updated the pull request with a new target base due to a merge or >> a rebase. The incremental webrev excludes the unrelated changes brought in >> by the merge/rebase. The pull request contains four additional commits since >>

Re: RFR: 8284942: Proxy building can just iterate superinterfaces once [v3]

2022-05-19 Thread liach
On Fri, 20 May 2022 00:08:36 GMT, Mandy Chung wrote: > a named module can't have unnamed package Since this is mandated by the Java Language Specification 7.4.2, I am tempted to change the thrown exception to `InternalError`, but I cannot find any restriction in the JVM Specification that

Re: RFR: 8284942: Proxy building can just iterate superinterfaces once [v3]

2022-05-19 Thread Mandy Chung
On Thu, 19 May 2022 23:44:12 GMT, liach wrote: >> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass, >> the interfaces are iterated twice. The two passes can be merged into one, >> yielding the whole proxy definition context (module, package, whether >> there's

Re: RFR: 8284942: Proxy building can just iterate superinterfaces once [v3]

2022-05-19 Thread liach
> Currently, in ProxyBuilder::mapToModule and ProxyBuilder::defineProxyClass, > the interfaces are iterated twice. The two passes can be merged into one, > yielding the whole proxy definition context (module, package, whether there's > package-private interface) when determining the module. >