Re: RFR: 8284950: CgroupV1 detection code should consider memory.swappiness [v17]

2022-05-12 Thread xpbob
On Thu, 12 May 2022 13:32:03 GMT, xpbob  wrote:

>> set memory.swappiness to 0,swap space will not be used 
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>> 
>> 
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>> Memory & Swap Limit: 100.00M
>> Maximum Processes Limit: 4194305 
>> 
>> =>
>> 
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>> Memory & Swap Limit: 50.00M
>> Maximum Processes Limit: 4194305
>
> xpbob has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   add test

Thanks for review.
@jerboaa
The expression is clearer after the change

-

PR: https://git.openjdk.java.net/jdk/pull/8285


Re: RFR: 8284950: CgroupV1 detection code should consider memory.swappiness [v17]

2022-05-12 Thread xpbob
On Thu, 12 May 2022 13:32:03 GMT, xpbob  wrote:

>> set memory.swappiness to 0,swap space will not be used 
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>> 
>> 
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>> Memory & Swap Limit: 100.00M
>> Maximum Processes Limit: 4194305 
>> 
>> =>
>> 
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>> Memory & Swap Limit: 50.00M
>> Maximum Processes Limit: 4194305
>
> xpbob has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   add test

Thanks for review.
@jerboaa
Added test in TestMemoryWithCgroupV1

-

PR: https://git.openjdk.java.net/jdk/pull/8285


Re: RFR: 8284950: CgroupV1 detection code should consider memory.swappiness [v17]

2022-05-12 Thread Severin Gehwolf
On Thu, 12 May 2022 13:32:03 GMT, xpbob  wrote:

>> set memory.swappiness to 0,swap space will not be used 
>> determine the value of memory.swappiness
>> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
>> 
>> 
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>> Memory & Swap Limit: 100.00M
>> Maximum Processes Limit: 4194305 
>> 
>> =>
>> 
>> Memory Limit: 50.00M
>> Memory Soft Limit: Unlimited
>> Memory & Swap Limit: 50.00M
>> Maximum Processes Limit: 4194305
>
> xpbob has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   add test

LGTM. Consider a better name for the test :)

test/hotspot/jtreg/containers/docker/TestMemoryWithCgroupV1.java line 90:

> 88: }
> 89: 
> 90: private static void testOperatingSystemMXBeanAwareness(String 
> memoryAllocation, String swapAllocation,

Please use a more telling name for this. Perhaps this? 
`testOSBeanSwappinessMemory`.

-

Marked as reviewed by sgehwolf (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8285


Re: RFR: 8284950: CgroupV1 detection code should consider memory.swappiness [v17]

2022-05-12 Thread xpbob
> set memory.swappiness to 0,swap space will not be used 
> determine the value of memory.swappiness
> https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
> 
> 
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 100.00M
> Maximum Processes Limit: 4194305 
> 
> =>
> 
> Memory Limit: 50.00M
> Memory Soft Limit: Unlimited
> Memory & Swap Limit: 50.00M
> Maximum Processes Limit: 4194305

xpbob has updated the pull request incrementally with one additional commit 
since the last revision:

  add test

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8285/files
  - new: https://git.openjdk.java.net/jdk/pull/8285/files/296a409e..93bc46a6

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8285&range=16
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8285&range=15-16

  Stats: 36 lines in 1 file changed: 29 ins; 0 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8285.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8285/head:pull/8285

PR: https://git.openjdk.java.net/jdk/pull/8285