Re: RFR: 8285097: Duplicate XML keys in XPATHErrorResources.java and XSLTErrorResources.java [v3]

2022-05-06 Thread Joe Wang
On Fri, 6 May 2022 14:33:50 GMT, Shruthi  wrote:

>> Removing the Duplicate keys present in XSLTErrorResources.java and 
>> XPATHErrorResources.java
>> 
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   Replace the ER_RTF_NOT_SUPPORTED_XRTREEFRAGSELECTWRAPPER key in 
> XPATHErrorResources language files

Changing resource bundles is not required as the L10n resource files update 
would cover that. As you've modified the files, you'll need to update the 
license header, using XPATHErrorResources_ja.java as an example and update the 
year and LastModified tag.

-

PR: https://git.openjdk.java.net/jdk/pull/8318


Re: RFR: 8285097: Duplicate XML keys in XPATHErrorResources.java and XSLTErrorResources.java [v3]

2022-05-06 Thread Tyler Steele
On Wed, 20 Apr 2022 15:48:54 GMT, Tyler Steele  wrote:

>> Shruthi has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Replace the ER_RTF_NOT_SUPPORTED_XRTREEFRAGSELECTWRAPPER key in 
>> XPATHErrorResources language files
>
> src/java.xml/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources.java
>  line 599:
> 
>> 597: 
>> 598:   { ER_ASNODEITERATOR_NOT_SUPPORTED_XRTREEFRAGSELECTWRAPPER,
>> 599:"asNodeIterator() not supported by XRTreeFragSelectWrapper"},
> 
> For this key, please review places where the old key was used to find places 
> where the new key was intended. I believe [this 
> line](https://github.com/openjdk/jdk/blob/master/src/java.xml/share/classes/com/sun/org/apache/xpath/internal/objects/XRTreeFragSelectWrapper.java#L155)
>  is an example.

[Here](https://github.com/openjdk/jdk/blob/64225e19995e81d2e836ce84befea1a01bb6c860/src/java.xml/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources_de.java#L595)
 is another usage where the other key is intended. I expect you will find 
similar references in at least some of the other translation files.

-

PR: https://git.openjdk.java.net/jdk/pull/8318


Re: RFR: 8285097: Duplicate XML keys in XPATHErrorResources.java and XSLTErrorResources.java [v3]

2022-05-06 Thread Tyler Steele
On Fri, 6 May 2022 14:33:50 GMT, Shruthi  wrote:

>> Removing the Duplicate keys present in XSLTErrorResources.java and 
>> XPATHErrorResources.java
>> 
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has updated the pull request incrementally with one additional commit 
> since the last revision:
> 
>   Replace the ER_RTF_NOT_SUPPORTED_XRTREEFRAGSELECTWRAPPER key in 
> XPATHErrorResources language files

Marked as reviewed by backwater...@github.com (no known OpenJDK username).

src/java.xml/share/classes/com/sun/org/apache/xpath/internal/res/XPATHErrorResources.java
 line 599:

> 597: 
> 598:   { ER_ASNODEITERATOR_NOT_SUPPORTED_XRTREEFRAGSELECTWRAPPER,
> 599:"asNodeIterator() not supported by XRTreeFragSelectWrapper"},

For this key, please review places where the old key was used to find places 
where the new key was intended. I believe [this 
line](https://github.com/openjdk/jdk/blob/master/src/java.xml/share/classes/com/sun/org/apache/xpath/internal/objects/XRTreeFragSelectWrapper.java#L155)
 is an example.

-

PR: https://git.openjdk.java.net/jdk/pull/8318


Re: RFR: 8285097: Duplicate XML keys in XPATHErrorResources.java and XSLTErrorResources.java [v3]

2022-05-06 Thread Shruthi
> Removing the Duplicate keys present in XSLTErrorResources.java and 
> XPATHErrorResources.java
> 
> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097

Shruthi has updated the pull request incrementally with one additional commit 
since the last revision:

  Replace the ER_RTF_NOT_SUPPORTED_XRTREEFRAGSELECTWRAPPER key in 
XPATHErrorResources language files

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8318/files
  - new: https://git.openjdk.java.net/jdk/pull/8318/files/d53ca37e..c294a150

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8318=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8318=01-02

  Stats: 10 lines in 10 files changed: 0 ins; 0 del; 10 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8318.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8318/head:pull/8318

PR: https://git.openjdk.java.net/jdk/pull/8318