Re: RFR: 8285097: Duplicate XML keys in XPATHErrorResources.java and XSLTErrorResources.java [v5]

2022-05-09 Thread Joe Wang
On Mon, 9 May 2022 07:00:34 GMT, Shruthi  wrote:

>> Removing the Duplicate keys present in XSLTErrorResources.java and 
>> XPATHErrorResources.java
>> 
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has refreshed the contents of this pull request, and previous commits 
> have been removed. The incremental views will show differences compared to 
> the previous content of the PR. The pull request contains one new commit 
> since the last revision:
> 
>   Add last modified tag

After the last update, the years in the copyright header and LastModified tag 
do not match. For example, the header for XPATHErrorResources_de.java starts 
like: Copyright (c) 2019, 2021, where 2021 needs to be updated to 2022. When I 
mentioned using XPATHErrorResources_ja.java as an example, I meant replacing 
"reserved comment block" with the copyright header and then update the 
copyright year. Sorry if I wasn't clear enough. But basically using that as a 
template for the format of the header, and keep the year updated to the 
current. Thanks.

-

PR: https://git.openjdk.java.net/jdk/pull/8318


Re: RFR: 8285097: Duplicate XML keys in XPATHErrorResources.java and XSLTErrorResources.java [v5]

2022-05-09 Thread Shruthi
On Mon, 9 May 2022 07:00:34 GMT, Shruthi  wrote:

>> Removing the Duplicate keys present in XSLTErrorResources.java and 
>> XPATHErrorResources.java
>> 
>> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097
>
> Shruthi has refreshed the contents of this pull request, and previous commits 
> have been removed. The incremental views will show differences compared to 
> the previous content of the PR. The pull request contains one new commit 
> since the last revision:
> 
>   Add last modified tag

`/integrate`

-

PR: https://git.openjdk.java.net/jdk/pull/8318


Re: RFR: 8285097: Duplicate XML keys in XPATHErrorResources.java and XSLTErrorResources.java [v5]

2022-05-09 Thread Shruthi
> Removing the Duplicate keys present in XSLTErrorResources.java and 
> XPATHErrorResources.java
> 
> The bug report for the same: https://bugs.openjdk.java.net/browse/JDK-8285097

Shruthi has refreshed the contents of this pull request, and previous commits 
have been removed. The incremental views will show differences compared to the 
previous content of the PR. The pull request contains one new commit since the 
last revision:

  Add last modified tag

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8318/files
  - new: https://git.openjdk.java.net/jdk/pull/8318/files/ef9d..b1dcd44c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=8318&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=8318&range=03-04

  Stats: 943 lines in 1 file changed: 0 ins; 943 del; 0 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8318.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8318/head:pull/8318

PR: https://git.openjdk.java.net/jdk/pull/8318