Re: RFR: 8285285: Avoid redundant allocations in WindowsPreferences

2022-06-06 Thread Andrey Turbanov 
On Wed, 20 Apr 2022 19:16:00 GMT, Andrey Turbanov  wrote:

> 1. No need to call `String.substring` if you need need to compare start of 
> string with some constant. `String.startWith` suites better.
> 2. Unused String array is allocated in `childrenNamesSpi` method

Thank you for review!

-

PR: https://git.openjdk.java.net/jdk/pull/8322

Re: RFR: 8285285: Avoid redundant allocations in WindowsPreferences

2022-06-03 Thread Andrey Turbanov 
On Wed, 20 Apr 2022 19:16:00 GMT, Andrey Turbanov  wrote:

> 1. No need to call `String.substring` if you need need to compare start of 
> string with some constant. `String.startWith` suites better.
> 2. Unused String array is allocated in `childrenNamesSpi` method

I believe it's pretty obvious changes. I will integrate at Monday, if there 
will be no more comments.

-

PR: https://git.openjdk.java.net/jdk/pull/8322

Re: RFR: 8285285: Avoid redundant allocations in WindowsPreferences

2022-05-10 Thread Jaikiran Pai 
On Wed, 20 Apr 2022 19:16:00 GMT, Andrey Turbanov  wrote:

> 1. No need to call `String.substring` if you need need to compare start of 
> string with some constant. `String.startWith` suites better.
> 2. Unused String array is allocated in `childrenNamesSpi` method

Marked as reviewed by jpai (Committer).

I don't have knowledge of this area, but these changes look good to me.

-

PR: https://git.openjdk.java.net/jdk/pull/8322