Re: RFR: 8286560: Remove user parameter from jdk.internal.perf.Perf.attach() [v2]

2022-05-12 Thread Ioi Lam
On Thu, 12 May 2022 04:06:44 GMT, David Holmes  wrote:

>> Ioi Lam has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   @AlanBateman comments - remove thros IllegalArgumentException clause
>
> Nice cleanup! I checked back in JDK 7 and couldn't find any use of this 
> particular API.
> 
> Thanks.

Thanks to @dholmes-ora and @AlanBateman for the review.

-

PR: https://git.openjdk.java.net/jdk/pull/8669


Re: RFR: 8286560: Remove user parameter from jdk.internal.perf.Perf.attach() [v2]

2022-05-12 Thread Ioi Lam
On Thu, 12 May 2022 14:08:11 GMT, Alan Bateman  wrote:

>> Ioi Lam has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   @AlanBateman comments - remove thros IllegalArgumentException clause
>
> src/java.base/share/classes/jdk/internal/perf/Perf.java line 246:
> 
>> 244:  */
>> 245: private native ByteBuffer attach0(int lvmid)
>> 246:throws IllegalArgumentException, IOException;
> 
> You can drop the "throws IllegalArgumentException" here if you want, it's not 
> needed as it's a runtime exception.

Fixed.

-

PR: https://git.openjdk.java.net/jdk/pull/8669


Re: RFR: 8286560: Remove user parameter from jdk.internal.perf.Perf.attach() [v2]

2022-05-12 Thread Ioi Lam
> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never 
> used. It should be removed, and all the handling of a specified user name 
> should be removed.

Ioi Lam has updated the pull request incrementally with one additional commit 
since the last revision:

  @AlanBateman comments - remove thros IllegalArgumentException clause

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8669/files
  - new: https://git.openjdk.java.net/jdk/pull/8669/files/afa66232..0b73a9d4

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8669=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8669=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8669.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8669/head:pull/8669

PR: https://git.openjdk.java.net/jdk/pull/8669


Re: RFR: 8286560: Remove user parameter from jdk.internal.perf.Perf.attach()

2022-05-12 Thread Alan Bateman
On Wed, 11 May 2022 23:08:32 GMT, Ioi Lam  wrote:

> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never 
> used. It should be removed, and all the handling of a specified user name 
> should be removed.

Marked as reviewed by alanb (Reviewer).

src/java.base/share/classes/jdk/internal/perf/Perf.java line 246:

> 244:  */
> 245: private native ByteBuffer attach0(int lvmid)
> 246:throws IllegalArgumentException, IOException;

You can drop the "throws IllegalArgumentException" here if you want, it's not 
needed as it's a runtime exception.

-

PR: https://git.openjdk.java.net/jdk/pull/8669


Re: RFR: 8286560: Remove user parameter from jdk.internal.perf.Perf.attach()

2022-05-11 Thread David Holmes
On Wed, 11 May 2022 23:08:32 GMT, Ioi Lam  wrote:

> The API `jdk.internal.perf.Perf.::attach(String user, int lvmid)` is never 
> used. It should be removed, and all the handling of a specified user name 
> should be removed.

Nice cleanup! I checked back in JDK 7 and couldn't find any use of this 
particular API.

Thanks.

-

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8669