Re: RFR: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException [v3]
On Mon, 6 Jun 2022 14:58:25 GMT, Thiago Henrique Hüpner wrote: >> 8287353: Use snippet tag instead of pre tag in Javadoc of >> InterruptedException > > Thiago Henrique Hüpner has updated the pull request incrementally with one > additional commit since the last revision: > > Update copyright year Marked as reviewed by jpai (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8400
Re: RFR: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException [v3]
> 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Update copyright year - Changes: - all: https://git.openjdk.java.net/jdk/pull/8400/files - new: https://git.openjdk.java.net/jdk/pull/8400/files/f83dde2f..876f45c5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8400=02 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8400=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/8400.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8400/head:pull/8400 PR: https://git.openjdk.java.net/jdk/pull/8400
Re: RFR: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
On Wed, 27 Apr 2022 13:33:29 GMT, Thiago Henrique Hüpner wrote: >> 8287353: Use snippet tag instead of pre tag in Javadoc of >> InterruptedException > > If this is a valid change, could someone please create a Jira issue to link > to it? @Thihup Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See [OpenJDK Developers’ Guide](https://openjdk.java.net/guide/#working-with-pull-requests) for more information. - PR: https://git.openjdk.java.net/jdk/pull/8400
Re: RFR: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
On Wed, 27 Apr 2022 13:33:29 GMT, Thiago Henrique Hüpner wrote: >> 8287353: Use snippet tag instead of pre tag in Javadoc of >> InterruptedException > > If this is a valid change, could someone please create a Jira issue to link > to it? Hello @Thihup, overall this change looks fine to me. Can you please update the copyright year on that file's header to `Copyright (c) 1995, 2022,`? - PR: https://git.openjdk.java.net/jdk/pull/8400
Re: RFR: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException [v2]
> 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException Thiago Henrique Hüpner has updated the pull request incrementally with one additional commit since the last revision: Fix pull request comment - Changes: - all: https://git.openjdk.java.net/jdk/pull/8400/files - new: https://git.openjdk.java.net/jdk/pull/8400/files/6d091b81..f83dde2f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8400=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8400=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/8400.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8400/head:pull/8400 PR: https://git.openjdk.java.net/jdk/pull/8400
Re: RFR: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
On Tue, 26 Apr 2022 15:04:15 GMT, Thiago Henrique Hüpner
wrote:
> 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
src/java.base/share/classes/java/lang/InterruptedException.java line 35:
> 33: * this exception. The following code can be used to achieve
> 34: * this effect:
> 35: * {@snippet:
I recommend using `{@snippet lang=java :` instead, like in
https://github.com/openjdk/jdk/blob/6520843f86f638fe4d1e5b3358fab5799daca654/src/java.compiler/share/classes/javax/tools/JavaFileManager.java#L84
-
PR: https://git.openjdk.java.net/jdk/pull/8400
Re: RFR: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
On Tue, 26 Apr 2022 15:04:15 GMT, Thiago Henrique Hüpner wrote: > 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException (not a maintainer) You can make one yourself in https://bugreport.java.com. - PR: https://git.openjdk.java.net/jdk/pull/8400
Re: RFR: 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException
On Tue, 26 Apr 2022 15:04:15 GMT, Thiago Henrique Hüpner wrote: > 8287353: Use snippet tag instead of pre tag in Javadoc of InterruptedException If this is a valid change, could someone please create a Jira issue to link to it? - PR: https://git.openjdk.java.net/jdk/pull/8400
