Re: RFR: 8287520: Shrink x86_32 problemlists after JDK-8287437 [v2]

2022-05-31 Thread Aleksey Shipilev
> [JDK-8287137](https://bugs.openjdk.java.net/browse/JDK-8287137) added a bunch 
> of tests into problemlist. Those lists basically exclude every test that runs 
> with --enable-preview. 
> [JDK-8287437](https://bugs.openjdk.java.net/browse/JDK-8287437) makes it 
> better: it only disables Loom parts, even with --enable-preview. This allows 
> testing x86_32 on other preview features and avoids accidental bug slippage 
> in non-Loom code paths. We can and should shrink the problem lists now.
> 
> Additional testing:
>  - [x] Removed tests with Linux x86_32 fastdebug; mostly pass, some non-Loom 
> failures
>  - [x] Linux x86_32 fastdebug `tier1`
>  - [x] GHA run

Aleksey Shipilev has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains three additional 
commits since the last revision:

 - Merge branch 'master' into JDK-8287520-loom-x86-32-shrink
 - Keep GetEventWriter on problemlist
 - Fix

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/8946/files
  - new: https://git.openjdk.java.net/jdk/pull/8946/files/7c90ead6..a3c3db2b

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk=8946=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8946=00-01

  Stats: 38619 lines in 252 files changed: 17091 ins; 16971 del; 4557 mod
  Patch: https://git.openjdk.java.net/jdk/pull/8946.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/8946/head:pull/8946

PR: https://git.openjdk.java.net/jdk/pull/8946


Re: RFR: 8287520: Shrink x86_32 problemlists after JDK-8287437

2022-05-31 Thread Aleksey Shipilev
On Tue, 31 May 2022 11:44:27 GMT, Alan Bateman  wrote:

>> [JDK-8287137](https://bugs.openjdk.java.net/browse/JDK-8287137) added a 
>> bunch of tests into problemlist. Those lists basically exclude every test 
>> that runs with --enable-preview. 
>> [JDK-8287437](https://bugs.openjdk.java.net/browse/JDK-8287437) makes it 
>> better: it only disables Loom parts, even with --enable-preview. This allows 
>> testing x86_32 on other preview features and avoids accidental bug slippage 
>> in non-Loom code paths. We can and should shrink the problem lists now.
>> 
>> Additional testing:
>>  - [x] Removed tests with Linux x86_32 fastdebug; mostly pass, some non-Loom 
>> failures
>>  - [x] Linux x86_32 fastdebug `tier1`
>>  - [x] GHA run
>
> This looks okay.  If we get PR8939 in then it should be possible to do more 
> clear out of the exclude lists.

Thank you, @AlanBateman. Any other comments? I plan to integrate it soon.

-

PR: https://git.openjdk.java.net/jdk/pull/8946


Re: RFR: 8287520: Shrink x86_32 problemlists after JDK-8287437

2022-05-31 Thread Alan Bateman
On Mon, 30 May 2022 13:20:17 GMT, Aleksey Shipilev  wrote:

> [JDK-8287137](https://bugs.openjdk.java.net/browse/JDK-8287137) added a bunch 
> of tests into problemlist. Those lists basically exclude every test that runs 
> with --enable-preview. 
> [JDK-8287437](https://bugs.openjdk.java.net/browse/JDK-8287437) makes it 
> better: it only disables Loom parts, even with --enable-preview. This allows 
> testing x86_32 on other preview features and avoids accidental bug slippage 
> in non-Loom code paths. We can and should shrink the problem lists now.
> 
> Additional testing:
>  - [x] Removed tests with Linux x86_32 fastdebug; mostly pass, some non-Loom 
> failures
>  - [x] Linux x86_32 fastdebug `tier1`
>  - [ ] GHA run

This looks okay.  If we get PR8939 in then it should be possible to do more 
clear out of the exclude lists.

-

Marked as reviewed by alanb (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8946


Re: RFR: 8287520: Shrink x86_32 problemlists after JDK-8287437

2022-05-31 Thread Aleksey Shipilev
On Mon, 30 May 2022 13:20:17 GMT, Aleksey Shipilev  wrote:

> [JDK-8287137](https://bugs.openjdk.java.net/browse/JDK-8287137) added a bunch 
> of tests into problemlist. Those lists basically exclude every test that runs 
> with --enable-preview. 
> [JDK-8287437](https://bugs.openjdk.java.net/browse/JDK-8287437) makes it 
> better: it only disables Loom parts, even with --enable-preview. This allows 
> testing x86_32 on other preview features and avoids accidental bug slippage 
> in non-Loom code paths. We can and should shrink the problem lists now.
> 
> Additional testing:
>  - [x] Removed tests with Linux x86_32 fastdebug; mostly pass, some non-Loom 
> failures
>  - [x] Linux x86_32 fastdebug `tier1`
>  - [ ] GHA run

Open for reviews. The test failures on Windows x64 are known and are solved 
separately.

-

PR: https://git.openjdk.java.net/jdk/pull/8946