Re: RFR: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run

2022-06-02 Thread Aleksei Efimov
On Wed, 1 Jun 2022 15:41:57 GMT, Rob McKenna  wrote:

> Test change to silently pass if the test environment encounters a 
> NoRouteToHostException. These are intermittent at the moment but I will 
> attempt to find an alternative to the use of example.com in some follow up 
> work.

Looks good to me 

-

Marked as reviewed by aefimov (Committer).

PR: https://git.openjdk.java.net/jdk/pull/8974


Re: RFR: 8287672: jtreg test com/sun/jndi/ldap/LdapPoolTimeoutTest.java fails intermittently in nightly run

2022-06-01 Thread Daniel Fuchs
On Wed, 1 Jun 2022 15:41:57 GMT, Rob McKenna  wrote:

> Test change to silently pass if the test environment encounters a 
> NoRouteToHostException. These are intermittent at the moment but I will 
> attempt to find an alternative to the use of example.com in some follow up 
> work.

Marked as reviewed by dfuchs (Reviewer).

test/jdk/com/sun/jndi/ldap/LdapPoolTimeoutTest.java line 124:

> 122: System.err.println("MSG RTE: " + msg);
> 123: // assertCompletion may wrap a CommunicationException in an 
> RTE
> 124: assertTrue(msg != null);

LGTM. Nit: I believe there is an `assertNotNull()`

-

PR: https://git.openjdk.java.net/jdk/pull/8974