Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v5]

2022-06-08 Thread Lance Andersen
On Wed, 8 Jun 2022 14:51:59 GMT, Thiago Henrique Hüpner  
wrote:

>> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved 
>> flags is used
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix test message

Marked as reviewed by lancea (Reviewer).

-

PR: https://git.openjdk.java.net/jdk/pull/9049


Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v5]

2022-06-08 Thread Alan Bateman
On Wed, 8 Jun 2022 14:51:59 GMT, Thiago Henrique Hüpner  
wrote:

>> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved 
>> flags is used
>
> Thiago Henrique Hüpner has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fix test message

test/jdk/tools/jar/modularJar/Basic.java line 1050:

> 1048:  */
> 1049: @Test(dataProvider = "resolutionNames")
> 1050: public void 
> updateFooModuleResolutionDoNotResolveByDefaultAndWarnIfResolved(String 
> resolutionName, Predicate hasWarning) throws IOException {

Update the existing tests is good but overly long lines make it too hard to 
read (it will make future side-by-side view impossible). Can you trim all these 
lines down to something closer to the existing tests in this file?

-

PR: https://git.openjdk.java.net/jdk/pull/9049


Re: RFR: 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved flags is used [v5]

2022-06-08 Thread Thiago Henrique Hüpner
> 8287760: --do-not-resolve-by-default gets overwritten if --warn-if-resolved 
> flags is used

Thiago Henrique Hüpner has updated the pull request incrementally with one 
additional commit since the last revision:

  Fix test message

-

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/9049/files
  - new: https://git.openjdk.java.net/jdk/pull/9049/files/c4a719e3..c88bc754

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=9049&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=9049&range=03-04

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/9049.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/9049/head:pull/9049

PR: https://git.openjdk.java.net/jdk/pull/9049