Hi Rachna,
Ok, looks fine.
Thanks, Roger
On 12/1/2016 8:20 AM, Rachna Goel wrote:
Hi Roger,
Thanks for the review. Updated patch is :
http://cr.openjdk.java.net/~rgoel/JDK-8075577/webrev.02/
Please find some of my comments inlined.
On 30/11/16 10:17 PM, Roger Riggs wrote:
Hi
Hi Roger,
Thanks for the review. Updated patch is :
http://cr.openjdk.java.net/~rgoel/JDK-8075577/webrev.02/
Please find some of my comments inlined.
On 30/11/16 10:17 PM, Roger Riggs wrote:
Hi Rachna,
macosx//HostLocaleProviderAdapterImpl.java:
- line 172-177, might be a good place
Hi Rachna,
macosx//HostLocaleProviderAdapterImpl.java:
- line 172-177, might be a good place to use the new
ConcurrentMap.computeIfAbsent
- line 197: you could pre-size the StringBuilder since the target
length can be estimated
(unless they are all less than the default 16)
macosx
Looks good to me.
Masayoshi
On 11/22/2016 6:30 PM, Rachna Goel wrote:
Hi,
Please review fix for JDK-8075577.
Bug : https://bugs.openjdk.java.net/browse/JDK-8075577
webrev : http://cr.openjdk.java.net/~rgoel/JDK-8075577/webrev.01/
Fix is to introduce new private spi
