Re: RFR: JDK-8144300 : Java does not honor http.nonProxyHosts value having wildcard * both at end and start

[Chris Hegarty]

Pallavi,

On 01/03/18 14:46, Pallavi Sonal wrote:

Hi,

Please review the following change to fix JDK-8144300.

  


Bug : https://bugs.openjdk.java.net/browse/JDK-8144300

Webrev : http://cr.openjdk.java.net/~rpatil/8144300/webrev.00/


Looks ok to me. Please add the bugId to the @bug tag in the test
before pushing.

Thanks,
-Chris.

Re: RFR: JDK-8144300 : Java does not honor http.nonProxyHosts value having wildcard * both at end and start

[Daniel Fuchs]

Hi,

Looks reasonable to me.

best regards,

-- daniel

On 01/03/2018 14:46, Pallavi Sonal wrote:

Hi,

Please review the following change to fix JDK-8144300.

  


Bug : https://bugs.openjdk.java.net/browse/JDK-8144300

Webrev : http://cr.openjdk.java.net/~rpatil/8144300/webrev.00/

  


Whenever there is a wildcard(*) at either the beginning or the end of a 
hostname specified in the list of http.nonProxyHosts , the code works as 
expected and DIRECT connection is used for them. But in scenarios, where there 
is a wildcard both at the beginning and end of the hostname, proxy is used 
instead of DIRECT connection.

  


All the tier1 and tier2 Mach 5 tests have passed.

  


Thanks,

Pallavi Sonal