Re: RFR: JDK-8152467: remove uses of anachronistic array declarations for method return type
The Assignee field in JBS should be updated. This syntax is so weird it's probably not caught by https://errorprone.info/bugpattern/MixedArrayDimensions If not, you could try writing your own errorprone check for it. On Thu, Aug 15, 2019 at 9:47 AM Evgeny Mandrikov wrote: > Hello! > > Please review patch [1] for JDK-8152467 [2]. Also it needs a sponsor since > I have only author status in OpenJDK Census [3]. > > After this change tier1 tests pass and I don't see other occurrences to > replace in output of > ag "\)\s*\[\s*\]" src > > > With best regards, > Evgeny Mandrikov > > [1] http://cr.openjdk.java.net/~godin/8152467/webrev.00/ > [2] https://bugs.openjdk.java.net/browse/JDK-8152467 > [3] https://openjdk.java.net/census#godin >
Re: RFR: JDK-8152467: remove uses of anachronistic array declarations for method return type
On 19/08/2019 09:02, Aleksey Shipilev wrote: On 8/15/19 9:01 PM, Aleksey Shipilev wrote: On 8/15/19 6:46 PM, Evgeny Mandrikov wrote: [1] http://cr.openjdk.java.net/~godin/8152467/webrev.00/ This looks good. I also believe this qualifies as trivial patch. Yes, and looks okay although it's probably not worth spending time cleaning up rmic as it will be removed at some point (the need for it to generate static stubs mostly went away in JDK 5 and the tool has been deprecated for several releases). -Alan. I will be sponsoring the push. Now running through jdk-submit, to avoid surprises.
Re: RFR: JDK-8152467: remove uses of anachronistic array declarations for method return type
On 8/15/19 9:01 PM, Aleksey Shipilev wrote: > On 8/15/19 6:46 PM, Evgeny Mandrikov wrote: >> [1] http://cr.openjdk.java.net/~godin/8152467/webrev.00/ > > This looks good. I also believe this qualifies as trivial patch. I will be sponsoring the push. Now running through jdk-submit, to avoid surprises. -- Thanks, -Aleksey
Re: RFR: JDK-8152467: remove uses of anachronistic array declarations for method return type
On 8/15/19 6:46 PM, Evgeny Mandrikov wrote: > [1] http://cr.openjdk.java.net/~godin/8152467/webrev.00/ This looks good. -- Thanks, -Aleksey
