Re: RFR: JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618

2020-12-09 Thread Alexander Zuev
On Wed, 9 Dec 2020 18:58:54 GMT, Andy Herrick wrote: > Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed > up with merge Marked as reviewed by kizune (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1720

Re: RFR: JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618

2020-12-09 Thread Phil Race
On Wed, 9 Dec 2020 18:58:54 GMT, Andy Herrick wrote: > Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed > up with merge Marked as reviewed by prr (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/1720

Re: RFR: JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618

2020-12-09 Thread Alexey Semenyuk
On Wed, 9 Dec 2020 18:58:54 GMT, Andy Herrick wrote: > Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed > up with merge Marked as reviewed by asemenyuk (Committer). - PR: https://git.openjdk.java.net/jdk/pull/1720

Re: RFR: JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618

2020-12-09 Thread Alexander Matveev
On Wed, 9 Dec 2020 18:58:54 GMT, Andy Herrick wrote: > Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed > up with merge Marked as reviewed by almatvee (Committer). - PR: https://git.openjdk.java.net/jdk/pull/1720

Re: RFR: JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618

2020-12-08 Thread Andy Herrick
On Tue, 8 Dec 2020 14:56:20 GMT, Andy Herrick wrote: >> Looks like test failed due to: >> [Fatal Error] b.wxl:3:1: XML document structures must start and end within >> the same entity. >> So, I am not sure how increased repeat will help. Do we know why it failed >> to parse XML? > >> >> >>

Re: RFR: JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618 [v2]

2020-12-08 Thread Andy Herrick
> increase retries and timeout increasing in runMsiexecWithRetries Andy Herrick has updated the pull request incrementally with 18 additional commits since the last revision: - 8256149: Weird AST structure for incomplete member select Reviewed-by: vromero - 8257194: Add 'foreign linker

Re: RFR: JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618

2020-12-08 Thread Andy Herrick
On Tue, 8 Dec 2020 03:08:59 GMT, Alexander Matveev wrote: > > > Looks like test failed due to: > [Fatal Error] b.wxl:3:1: XML document structures must start and end within > the same entity. > So, I am not sure how increased repeat will help. Do we know why it failed to > parse XML? If you

Re: RFR: JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with Exit code: 1618

2020-12-07 Thread Alexander Matveev
On Mon, 7 Dec 2020 20:29:56 GMT, Andy Herrick wrote: > increase retries and timeout increasing in runMsiexecWithRetries Looks like test failed due to: [Fatal Error] b.wxl:3:1: XML document structures must start and end within the same entity. So, I am not sure how increased repeat will help.