Re: RFR: JDK-8285497: Add system property for Java SE specification maintenance version [v4]
On Thu, 28 Apr 2022 23:56:27 GMT, Mark Reinhold wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback; make sequence of values explicit.
>
> src/java.base/share/classes/java/lang/System.java line 740:
>
>> 738: * > href="https://jcp.org/en/procedures/jcp2#3.6.4;>maintenance
>> 739: * release (optional).
>> 740: * After a first maintenance release, this property will
>
> Separate independent clauses with a semicolon: `After a first maintenance
> release this property will have the value {@code "1"}; after a second
> maintenance release it will have the value {@code "2"}, and so on.`
PR and CSR updated.
-
PR: https://git.openjdk.java.net/jdk/pull/8437
Re: RFR: JDK-8285497: Add system property for Java SE specification maintenance version [v4]
On Thu, 28 Apr 2022 20:54:29 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties, for an initial release of a specification.
>>
>> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764
>>
>> I'll update copyright years before an integration.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback; make sequence of values explicit.
src/java.base/share/classes/java/lang/System.java line 740:
> 738: * href="https://jcp.org/en/procedures/jcp2#3.6.4;>maintenance
> 739: * release (optional).
> 740: * After a first maintenance release, this property will
Separate independent clauses with a semicolon: `After a first maintenance
release this property will have the value {@code "1"}; after a second
maintenance release it will have the value {@code "2"}, and so on.`
-
PR: https://git.openjdk.java.net/jdk/pull/8437
Re: RFR: JDK-8285497: Add system property for Java SE specification maintenance version [v4]
On Thu, 28 Apr 2022 20:54:29 GMT, Joe Darcy wrote: >> Add a new system property, java.specification.maintenance.version, to return >> the maintenance release number of the Java SE specification being >> implemented. The property is unset, optional in the terminology of >> System.getProperties, for an initial release of a specification. >> >> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764 >> >> I'll update copyright years before an integration. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback; make sequence of values explicit. Marked as reviewed by mullan (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8437
Re: RFR: JDK-8285497: Add system property for Java SE specification maintenance version [v4]
> Add a new system property, java.specification.maintenance.version, to return > the maintenance release number of the Java SE specification being > implemented. The property is unset, optional in the terminology of > System.getProperties, for an initial release of a specification. > > Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764 > > I'll update copyright years before an integration. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback; make sequence of values explicit. - Changes: - all: https://git.openjdk.java.net/jdk/pull/8437/files - new: https://git.openjdk.java.net/jdk/pull/8437/files/fc7730d6..461407aa Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8437=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8437=02-03 Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/8437.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8437/head:pull/8437 PR: https://git.openjdk.java.net/jdk/pull/8437
