Re: RFR: JDK-8285764: Add system property for Java SE specification maintenance version [v2]
On Thu, 28 Apr 2022 17:36:32 GMT, Joe Darcy wrote: >> Add a new system property, java.specification.maintenance.version, to return >> the maintenance release number of the Java SE specification being >> implemented. The property is unset, optional in the terminology of >> System.getProperties, for an initial release of a specification. >> >> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764 >> >> I'll update copyright years before an integration. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains five additional commits since > the last revision: > > - Respond to review feedback. > - Respond to CSR feedback. > - Merge branch 'master' into JDK-8285497 > - Update comment in template. > - JDK-8285497: Add system property for Java SE specification maintenance > version src/java.base/share/conf/security/java.policy line 34: > 32:"java.specification.version", "read"; > 33: permission java.util.PropertyPermission > 34:"java.specification.maintenance.version", "read"; For consistency, you should probably also add a hard-coded permission to the `sun.security.provider.PolicyFile.initStaticPolicy()` method which is used as a fallback if there is a problem parsing the `java.policy` file. I doubt this will cause any issues as I don't suspect many/any applications will suddenly start reading this property and running with an SM but again it is mainly for consistency as all the other default permissions in this file are also granted in that method. - PR: https://git.openjdk.java.net/jdk/pull/8437
Re: RFR: JDK-8285764: Add system property for Java SE specification maintenance version [v2]
On Thu, 28 Apr 2022 17:36:32 GMT, Joe Darcy wrote:
>> Add a new system property, java.specification.maintenance.version, to return
>> the maintenance release number of the Java SE specification being
>> implemented. The property is unset, optional in the terminology of
>> System.getProperties, for an initial release of a specification.
>>
>> Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764
>>
>> I'll update copyright years before an integration.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains five additional commits since
> the last revision:
>
> - Respond to review feedback.
> - Respond to CSR feedback.
> - Merge branch 'master' into JDK-8285497
> - Update comment in template.
> - JDK-8285497: Add system property for Java SE specification maintenance
> version
Also, don't forget to update the CSR with the new specification text, for the
record.
Otherwise, looks good!
src/java.base/share/classes/java/lang/VersionProps.java.template line 113:
> 111: props.put("java.specification.version", VERSION_SPECIFICATION);
> 112:
> 113: // Uncomment next props.put call after the first maintenance
> review for a
s/review/release/
-
Changes requested by mr (Lead).
PR: https://git.openjdk.java.net/jdk/pull/8437
Re: RFR: JDK-8285764: Add system property for Java SE specification maintenance version
On Thu, 28 Apr 2022 12:31:31 GMT, Sean Mullan wrote: > Should this be added to the default permissions in the > `conf/security/java.policy` file along with other similar properties? Seems reasonable; good catch. - PR: https://git.openjdk.java.net/jdk/pull/8437
Re: RFR: JDK-8285764: Add system property for Java SE specification maintenance version [v2]
> Add a new system property, java.specification.maintenance.version, to return > the maintenance release number of the Java SE specification being > implemented. The property is unset, optional in the terminology of > System.getProperties, for an initial release of a specification. > > Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764 > > I'll update copyright years before an integration. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Respond to review feedback. - Respond to CSR feedback. - Merge branch 'master' into JDK-8285497 - Update comment in template. - JDK-8285497: Add system property for Java SE specification maintenance version - Changes: - all: https://git.openjdk.java.net/jdk/pull/8437/files - new: https://git.openjdk.java.net/jdk/pull/8437/files/4ea4708b..101ad872 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=8437=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=8437=00-01 Stats: 670 lines in 38 files changed: 614 ins; 8 del; 48 mod Patch: https://git.openjdk.java.net/jdk/pull/8437.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/8437/head:pull/8437 PR: https://git.openjdk.java.net/jdk/pull/8437
Re: RFR: JDK-8285764: Add system property for Java SE specification maintenance version
On Wed, 27 Apr 2022 22:27:34 GMT, Joe Darcy wrote: > Add a new system property, java.specification.maintenance.version, to return > the maintenance release number of the Java SE specification being > implemented. The property is unset, optional in the terminology of > System.getProperties, for an initial release of a specification. > > Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764 > > I'll update copyright years before an integration. Should this be added to the default permissions in the `lib/security/java.policy` file along with other similar properties? - PR: https://git.openjdk.java.net/jdk/pull/8437
Re: RFR: JDK-8285764: Add system property for Java SE specification maintenance version
On Wed, 27 Apr 2022 22:27:34 GMT, Joe Darcy wrote: > Add a new system property, java.specification.maintenance.version, to return > the maintenance release number of the Java SE specification being > implemented. The property is unset, optional in the terminology of > System.getProperties, for an initial release of a specification. > > Please also review the CSR https://bugs.openjdk.java.net/browse/JDK-8285764 > > I'll update copyright years before an integration. Hello Joe, should the property description have a note stating what kind of a value this property holds, if at all present? Would it be free form text or an integer value? - PR: https://git.openjdk.java.net/jdk/pull/8437
