Re: RFR:JDK-8075205 java/net/URLClassLoader/closetest/CloseTest.java and GetResourceAsStream.java failed with existing dir

2016-10-27 Thread Roger Riggs
Hi, Looks good. Editorial improvements: GetResourceAsStream.java: - line 44-52: Add the new variables after the test description like CloseTest.java or change CloseTest to improve style consistency. - Line 54-57: fix indentation - consistently use /* ... */ or // comment

Re: RFR:JDK-8075205 java/net/URLClassLoader/closetest/CloseTest.java and GetResourceAsStream.java failed with existing dir

2016-10-25 Thread Srinivasan Raghavan
Hi all Please help with one more reviewer comment. Regards Srinivasan Raghavan > On 19-Oct-2016, at 9:38 AM, Srinivasan Raghavan > wrote: > > Thanks for the review. >> On 18-Oct-2016, at 4:16 PM, Chris Hegarty wrote: >> >> >>> On

Re: RFR:JDK-8075205 java/net/URLClassLoader/closetest/CloseTest.java and GetResourceAsStream.java failed with existing dir

2016-10-18 Thread Srinivasan Raghavan
Thanks for the review. > On 18-Oct-2016, at 4:16 PM, Chris Hegarty wrote: > > >> On 17 Oct 2016, at 09:51, Srinivasan Raghavan >> wrote: >> >> Hi all >> >> Please review the fix for the bug >> >> Bug

Re: RFR:JDK-8075205 java/net/URLClassLoader/closetest/CloseTest.java and GetResourceAsStream.java failed with existing dir

2016-10-18 Thread Chris Hegarty
> On 17 Oct 2016, at 09:51, Srinivasan Raghavan > wrote: > > Hi all > > Please review the fix for the bug > > Bug :https://bugs.openjdk.java.net/browse/JDK-8075205 > > The tests uses classes directory for the output files. This can result in the > files