Re: RFR (JAXP) 8167340: XMLStreamReader.getElementText return corrupt content when size of element is > 8192

On 01/12/16 17:25, Joe Wang wrote: Thanks Christoph, Daniel! I've updated the test, removing the comments. As for 80 chars line limit, or slightly longer than that is fine with me. Given our codebase, it would be an enormous undertaking. I'm therefore fine with taking care of only the extremely

RE: RFR (JAXP) 8167340: XMLStreamReader.getElementText return corrupt content when size of element is > 8192

izhe.w...@oracle.com] > Sent: Donnerstag, 1. Dezember 2016 18:25 > To: Daniel Fuchs <daniel.fu...@oracle.com> > Cc: Langer, Christoph <christoph.lan...@sap.com>; core-libs- > d...@openjdk.java.net > Subject: Re: RFR (JAXP) 8167340: XMLStreamReader.getElementText return >

Re: RFR (JAXP) 8167340: XMLStreamReader.getElementText return corrupt content when size of element is > 8192

Thanks Christoph, Daniel! I've updated the test, removing the comments. As for 80 chars line limit, or slightly longer than that is fine with me. Given our codebase, it would be an enormous undertaking. I'm therefore fine with taking care of only the extremely long ones or any that impedes

Re: RFR (JAXP) 8167340: XMLStreamReader.getElementText return corrupt content when size of element is > 8192

Thanks Lance! I've re-created the webrev with the one-line change: webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8167340/webrev/ I'll use https://bugs.openjdk.java.net/browse/JDK-8170556 for the cleanup, will expand to cover the

Re: RFR (JAXP) 8167340: XMLStreamReader.getElementText return corrupt content when size of element is > 8192

Hi Joe, I agree with Christoph's comments below. +1 best regards, -- daniel On 01/12/16 07:40, Langer, Christoph wrote: Hi Joe, to me this looks good. Did you already remove the cleanups from http://cr.openjdk.java.net/~joehw/jdk9/8167340/webrev/ ? I can't see a lot of them any more...

RE: RFR (JAXP) 8167340: XMLStreamReader.getElementText return corrupt content when size of element is > 8192

Hi Joe, to me this looks good. Did you already remove the cleanups from http://cr.openjdk.java.net/~joehw/jdk9/8167340/webrev/ ? I can't see a lot of them any more... A few minor points: It seems you still have left some debugging code in

Re: RFR (JAXP) 8167340: XMLStreamReader.getElementText return corrupt content when size of element is > 8192

Hi Joe Looks OK. I might suggest a separate issue for the cleanup and just have this bug address the bug fix Best Lance > On Nov 30, 2016, at 4:21 PM, Joe Wang wrote: > > Hi, > > Please review an one-line fix and a bunch of cleanups. > > The reported issue was