Re: RFR (JAXP) JDK-8167478 javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with "java.security.AccessControlException: access denied ("java.io.FilePermission" "sko?ice")"

2016-10-16 Thread Wang Weijun
http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/037c095ba0c345edbeaaab52fda913a76c3930c0 My understanding is that if the changeset already has your name as the author then there is no need to add your name again into Contributed-by. --Max > On Oct 17, 2016, at 10:13 AM, Frank Yuan

RE: RFR (JAXP) JDK-8167478 javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with "java.security.AccessControlException: access denied ("java.io.FilePermission" "sko?ice")"

2016-10-16 Thread Frank Yuan
Alright, thank you! Then I will check it in. Frank > -Original Message- > From: Joe Wang [mailto:huizhe.w...@oracle.com] > Subject: Re: RFR (JAXP) JDK-8167478 > javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with > "java.security.AccessControlExcept

Re: RFR (JAXP) JDK-8167478 javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with "java.security.AccessControlException: access denied ("java.io.FilePermission" "sko?ice")"

2016-10-14 Thread Joe Wang
. Please check the new webrev http://cr.openjdk.java.net/~fyuan/8167478/webrev.01/ Thanks Frank -Original Message- From: Leo Jiang [mailto:li.ji...@oracle.com] Subject: Re: RFR (JAXP) JDK-8167478 javax/xml/jaxp/unittest/parsers/Bug6341770.java failed

RE: RFR (JAXP) JDK-8167478 javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with "java.security.AccessControlException: access denied ("java.io.FilePermission" "sko?ice")"

2016-10-14 Thread Frank Yuan
Frank > -Original Message- > From: Leo Jiang [mailto:li.ji...@oracle.com] > Subject: Re: RFR (JAXP) JDK-8167478 > javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with > "java.security.AccessControlException: > access denied ("java.io.FilePermission"

Re: RFR (JAXP) JDK-8167478 javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with "java.security.AccessControlException: access denied ("java.io.FilePermission" "sko?ice")"

2016-10-13 Thread Leo Jiang
Hi Frank, I suggest you to use the following code snippet to make your code more readable. CharsetEncoder charsetEncoder = Charset.defaultCharset().newEncoder(); boolean b = charsetEncoder.canEncode(path);// alpha Any character in Unicode range would be valid as path if current

RE: RFR (JAXP) JDK-8167478 javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with "java.security.AccessControlException: access denied ("java.io.FilePermission" "sko?ice")"

2016-10-13 Thread Frank Yuan
Thank you, will change it. Frank > -Original Message- > From: Felix Yang [mailto:felix.y...@oracle.com] > Subject: Re: RFR (JAXP) JDK-8167478 > javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with "java.security.AccessControlException: > access denied (&qu

Re: RFR (JAXP) JDK-8167478 javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with "java.security.AccessControlException: access denied ("java.io.FilePermission" "sko?ice")"

2016-10-13 Thread Joe Wang
Hi Frank, Does this work as expected? The method doesn't seem to validate whether a character is legal as a file name. For example, on Windows, the original char (e.g. \u0159) used in the test is legal in a file name, but it didn't pass that decode/encode test by the Windows' default

Re: RFR (JAXP) JDK-8167478 javax/xml/jaxp/unittest/parsers/Bug6341770.java failed with "java.security.AccessControlException: access denied ("java.io.FilePermission" "sko?ice")"

2016-10-13 Thread Felix Yang
A comment on naming, alpha to ALPHA ? -Felix > 在 2016年10月13日，17:05，Frank Yuan 写道： > > Hi all > > > > Would you like to review http://cr.openjdk.java.net/~fyuan/8167478/webrev.00/ > ? > > Bug: https://bugs.openjdk.java.net/browse/JDK-8167478 > > > > This is a test