Thanks Ivan, I merged your changes with mine and pushed the resulting changeset.
> On 20 Mar 2020, at 20:11, Ivan Gerasimov wrote:
>
> Thank you Paul!
>
> grep found a few more occurrences of 'equals to' across java.base, so I
> fixed them as well.
>
> Here's the updated webrev:
>
>
Thank you Paul!
grep found a few more occurrences of 'equals to' across java.base, so
I fixed them as well.
Here's the updated webrev:
http://cr.openjdk.java.net/~igerasim/XXX-typos/01/webrev/
Pavel, I checked your portion of correction, everything looks good to me!
One minor nit:
+1
Paul.
> On Mar 13, 2020, at 8:42 AM, Pavel Rappo wrote:
>
> Hello,
>
> Please review the change for https://bugs.openjdk.java.net/browse/JDK-8241014:
>
> http://cr.openjdk.java.net/~prappo/8241014/webrev.00/
>
> This is a documentation cleanup. There are no code changes involved,
> and
--- a/src/java.base/share/classes/java/lang/invoke/MethodType.java
+++ b/src/java.base/share/classes/java/lang/invoke/MethodType.java
@@ -1379,12 +1379,12 @@
/**
* This implementation returns {@code true} if {@code obj} is
another
- * {@code WeakEntry}
Hi Ivan,
Your changes look good to me. Thanks for doing this.
I will merge your changes into that patch of mine.
1. One thing that your change highlighted is that use of FQN here:
public int read(java.nio.CharBuffer target) throws IOException
It's been there for ages, but I believe can now
Looks fine.
On 3/13/20 11:42 AM, Pavel Rappo wrote:
Hello,
Please review the change for https://bugs.openjdk.java.net/browse/JDK-8241014:
http://cr.openjdk.java.net/~prappo/8241014/webrev.00/
This is a documentation cleanup. There are no code changes involved,
and the changes in
