Re: RFR [15] 8248233: Avoid superfluous Class::isRecord invocations during deserialization

On 6/24/20 6:53 PM, Chris Hegarty wrote: On 24 Jun 2020, at 17:15, Claes Redestad > wrote: ... It seems ObjectInputStream#isRecord(Class) is now unused. No need for a new webrev if you choose to remove it. Good catch, now removed. On 24 Jun 2020, at

Re: RFR [15] 8248233: Avoid superfluous Class::isRecord invocations during deserialization

> On 24 Jun 2020, at 17:15, Claes Redestad wrote: > > ... > It seems ObjectInputStream#isRecord(Class) is now unused. No need for > a new webrev if you choose to remove it. Good catch, now removed. > On 24 Jun 2020, at 17:25, Peter Levart wrote: > > Hi Chris, > > The patch looks good. >

Re: RFR [15] 8248233: Avoid superfluous Class::isRecord invocations during deserialization

Hi Chris, The patch looks good. Before the patch it made sense to have if (cl != null) in line 750 in ObjectStreamClass, but now nothing in the if block depends on cl, so you could use if (osc != null) instead. It is true that: (cl != null) == (osc != null) always holds there, but

Re: RFR [15] 8248233: Avoid superfluous Class::isRecord invocations during deserialization

Hi Chris, On 2020-06-24 17:46, Chris Hegarty wrote: A micro-optimisation noticed when working on JDK-8247532. For further details see: https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-June/067446.html Webrev: https://cr.openjdk.java.net/~chegar/8248233/webrev.00/ This looks