Re: RFR 8165372 : StackWalker performance regression following JDK-8147039

2016-09-19 Thread Mandy Chung 
+1

Mandy

> On Sep 19, 2016, at 3:57 PM, Brent Christian  
> wrote:
> 
> Thanks for the good suggestions.  Webrev updated in place:
> http://cr.openjdk.java.net/~bchristi/8165372/webrev.00/
> 
> -Brent
>

Re: RFR 8165372 : StackWalker performance regression following JDK-8147039

2016-09-19 Thread Brent Christian 

Thanks for the good suggestions.  Webrev updated in place:
http://cr.openjdk.java.net/~bchristi/8165372/webrev.00/

-Brent

Re: RFR 8165372 : StackWalker performance regression following JDK-8147039

2016-09-19 Thread Mandy Chung 

> On Sep 19, 2016, at 12:35 PM, Brent Christian  
> wrote:
> 
> Hi,
> 
> Please review my fix for 8165372 : "StackWalker performance regression 
> following JDK-8147039"
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8165372
> Webrev: http://cr.openjdk.java.net/~bchristi/8165372/webrev.00/
> 

This looks good and clean.  I have the same comment what Coleen pointed out:
  + if (need_method_info(mode) == false && get_caller_class(mode) &&

and Handle stackFrame.

Mandy