Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

Hi Florian, Thanks for the reminder, I'll add it to 8196716 Refactor FileDescriptor FDCleanup Thanks, Roger On 2/4/2018 4:17 PM, Florian Weimer wrote: * Roger Riggs: Updated in place.   http://cr.openjdk.java.net/~rriggs/webrev-net-clean

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

* Roger Riggs: > Updated in place. >   http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/ Doesn't this leak the file descriptor of SocketCleanable.register throws?

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

Hi Peter, I filed a new issue for the cleanup:    https://bugs.openjdk.java.net/browse/JDK-8196716 On 2/2/2018 1:16 PM, Peter Levart wrote: Hi Roger, Nice separation of concerns (io vs. net). Is JavaIOFileDescriptorAccess.registerCleanup(FileDescriptor) currently used at all? I have not gott

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

Hi Roger, Nice separation of concerns (io vs. net). Is JavaIOFileDescriptorAccess.registerCleanup(FileDescriptor) currently used at all? Although not necessary for this patch, but to make code more symmetric, FileDecriptor.FDCleaner could also be extracted into a package-private top class a

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

On 02/02/18 17:07, Roger Riggs wrote: Hi Chris, Updated in place. http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/ Looks good to me. Trivially ( no need to re-generate the webrev ), in windows SocketImpl.c java*_net*_java_net_SocketCleanable -Chris.

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

Hi Chris, Updated in place.   http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/ Thanks, Roger On 2/2/2018 11:30 AM, Chris Hegarty wrote: Roger, On 01/02/18 21:29, Roger Riggs wrote: Hi Chris, Thanks for the review and suggestion. Webrev updated: http://cr.openjdk.java.net/~rr

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

Roger, On 01/02/18 21:29, Roger Riggs wrote: Hi Chris, Thanks for the review and suggestion. Webrev updated: http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/ This looks good to me, just a few small comments: 1) windows SocketImpl.c in the comments: java_net_AbstractPlainS

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

Hi Chris, Thanks for the review and suggestion. Webrev updated:    http://cr.openjdk.java.net/~rriggs/webrev-net-cleanup-8195059/ * Refactored SocketCleanup into a java.net package private SocketCleanable * Moved register and unregister into static methods in SocketCleanable * Simplified the

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

Hi Roger, > On 31 Jan 2018, at 15:52, Roger Riggs wrote: > > Adding net-...@openjdk.java.net > > On 1/30/2018 5:08 PM, Roger Riggs wrote: >> Please review changes to replace finalizers in socket, datagram, and >> multicast networking >> with Cleaner based release of the raw file descriptors.

Re: RFR 8195059: Update java.net Socket and DatagramSocket implementations to use Cleaner

Adding net-...@openjdk.java.net On 1/30/2018 5:08 PM, Roger Riggs wrote: Please review changes to replace finalizers in socket, datagram, and multicast networking with Cleaner based release of the raw file descriptors.  Each FileDescriptor is registered for cleanup after the raw fd (or handle)