Re: Review Request JDK-8215238: (jdeps) update jdk8_internals.txt per the removal of javafx, corba, EE modules

[Alan Bateman]

On 11/12/2018 23:57, Mandy Chung wrote:

Several modules including Java EE and CORBA modules [1] and
JavaFX and a few other modules have been removed from JDK.

jdeps maintains a list of JDK 8 internal API packages that
`jdeps -jdkinternals` can properly flag that a reference to
JDK 8 internal API that was renamed or removed while the
feature is still supported.  For these removed modules,
their internal API packages should be handled as non-JDK
API and reports missing dependency if not found.  The patch
is simple and the main change is to remove them from the
`jdk8_internals.txt` resource file.

Webrev:
http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8215238/webrev.00/

Looks good.

Re: Review Request JDK-8215238: (jdeps) update jdk8_internals.txt per the removal of javafx, corba, EE modules

[Lance Andersen]

+1
> On Dec 11, 2018, at 6:57 PM, Mandy Chung  wrote:
> 
> Several modules including Java EE and CORBA modules [1] and
> JavaFX and a few other modules have been removed from JDK.
> 
> jdeps maintains a list of JDK 8 internal API packages that
> `jdeps -jdkinternals` can properly flag that a reference to
> JDK 8 internal API that was renamed or removed while the
> feature is still supported.  For these removed modules,
> their internal API packages should be handled as non-JDK
> API and reports missing dependency if not found.  The patch
> is simple and the main change is to remove them from the
> `jdk8_internals.txt` resource file.
> 
> Webrev:
> http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8215238/webrev.00/
> 
> Thanks
> Mandy
> [1] http://openjdk.java.net/jeps/320

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com