Re: hg: jdk7/tl/jdk: 2 new changesets
Hey Mike, why didn't you follow Mark's explanation about the naming for StandardCharset(s) ? Did you have had other discussions internally? -Ulf Am 27.04.2011 23:18, schrieb mike.dui...@oracle.com: Changeset: 5b05f8d1c0e5 Author:mduigou Date: 2011-04-26 14:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5b05f8d1c0e5 4884238: Adds java.nio.charset.StandardCharset to provide static final constants for the standard charsets. Reviewed-by: alanb, sherman, darcy ! src/share/classes/java/nio/charset/Charset.java + src/share/classes/java/nio/charset/StandardCharset.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/util/zip/ZipCoder.java ! src/share/classes/java/util/zip/ZipFile.java ! src/share/classes/java/util/zip/ZipInputStream.java ! src/share/classes/java/util/zip/ZipOutputStream.java ! src/share/classes/sun/awt/FontDescriptor.java + test/java/nio/charset/StandardCharset/Standard.java Changeset: bf2a12c1ffe3 Author:mduigou Date: 2011-04-27 14:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf2a12c1ffe3 Merge
Re: hg: jdk7/tl/jdk: 2 new changesets
Essentially we ran out of time for this task and were confident enough in out decision about the design and choice of names to go ahead. More discussion didn't seem to be leading anywhere but inaction and there are other issues (always) that need attention. Mike On Apr 28 2011, at 10:15 , Ulf Zibis wrote: Hey Mike, why didn't you follow Mark's explanation about the naming for StandardCharset(s) ? Did you have had other discussions internally? -Ulf Am 27.04.2011 23:18, schrieb mike.dui...@oracle.com: Changeset: 5b05f8d1c0e5 Author:mduigou Date: 2011-04-26 14:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5b05f8d1c0e5 4884238: Adds java.nio.charset.StandardCharset to provide static final constants for the standard charsets. Reviewed-by: alanb, sherman, darcy ! src/share/classes/java/nio/charset/Charset.java + src/share/classes/java/nio/charset/StandardCharset.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/util/zip/ZipCoder.java ! src/share/classes/java/util/zip/ZipFile.java ! src/share/classes/java/util/zip/ZipInputStream.java ! src/share/classes/java/util/zip/ZipOutputStream.java ! src/share/classes/sun/awt/FontDescriptor.java + test/java/nio/charset/StandardCharset/Standard.java Changeset: bf2a12c1ffe3 Author:mduigou Date: 2011-04-27 14:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf2a12c1ffe3 Merge
Re: hg: jdk7/tl/jdk: 2 new changesets
Thanks for the feedback. (but still waiting for the other one about static methods) -Ulf Am 28.04.2011 19:38, schrieb Mike Duigou: Essentially we ran out of time for this task and were confident enough in out decision about the design and choice of names to go ahead. More discussion didn't seem to be leading anywhere but inaction and there are other issues (always) that need attention. Mike On Apr 28 2011, at 10:15 , Ulf Zibis wrote: Hey Mike, why didn't you follow Mark's explanation about the naming for StandardCharset(s) ? Did you have had other discussions internally? -Ulf Am 27.04.2011 23:18, schrieb mike.dui...@oracle.com: Changeset: 5b05f8d1c0e5 Author:mduigou Date: 2011-04-26 14:25 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/5b05f8d1c0e5 4884238: Adds java.nio.charset.StandardCharset to provide static final constants for the standard charsets. Reviewed-by: alanb, sherman, darcy ! src/share/classes/java/nio/charset/Charset.java + src/share/classes/java/nio/charset/StandardCharset.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/util/zip/ZipCoder.java ! src/share/classes/java/util/zip/ZipFile.java ! src/share/classes/java/util/zip/ZipInputStream.java ! src/share/classes/java/util/zip/ZipOutputStream.java ! src/share/classes/sun/awt/FontDescriptor.java + test/java/nio/charset/StandardCharset/Standard.java Changeset: bf2a12c1ffe3 Author:mduigou Date: 2011-04-27 14:18 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/bf2a12c1ffe3 Merge
Re: hg: jdk7/tl/jdk: 2 new changesets
Hi Rob, Rob Leland wrote: ..Mandy, Three questions. -import java.util.logging.Logger; +import sun.util.logging.PlatformLogger; It seems counter intuitive that a dependency would be change from a java.* - sun.* since this the OpenJDK ,why not add it to java.util.log.* ? Alan answered this question (thanks Alan). sun.util.logging.PlatformLogger is a private unsupported API added for internal JDK implementation use. Then the JavaDocs says : This enables the runtime components to eliminate the static dependency of the logging facility In addition, the PlatformLogger API can be used if the logging module does not exist. What use case required this ? Then is this meant to be similar to Apache commons-logging which also has a basic logging functionality ? No. PlatformLogger is not designed to provide basic logging functionality but instead as a proxy to avoid direct dependency on java.util.logging for internal use. I guess the last sentence caused the confusion. Mandy On 9/18/2009 9:51 PM, mandy.ch...@sun.com wrote: Changeset: d3281fa8e46c Author:mchung Date: 2009-09-17 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3281fa8e46c 6882376: Add internal support for JRE implementation to eliminate the dependency on logging Summary: Added sun.util.logging.PlatformLogger for JRE implementation to log messages. Reviewed-by: alanb, naoto ! make/java/logging/Makefile ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/LogRecord.java ! src/share/classes/sun/util/LocaleServiceProviderPool.java + src/share/classes/sun/util/logging/PlatformLogger.java ! src/windows/classes/java/util/prefs/WindowsPreferences.java + test/sun/util/logging/PlatformLoggerTest.java Changeset: 7b4e73ca6fd7 Author:mchung Date: 2009-09-18 17:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b4e73ca6fd7 Merge __ Information from ESET NOD32 Antivirus, version of virus signature database 4439 (20090918) __ The message was checked by ESET NOD32 Antivirus. http://www.eset.com
Re: hg: jdk7/tl/jdk: 2 new changesets
..Mandy, Three questions. Then the JavaDocs says : This enables the runtime components to eliminate the static dependency of the logging facility In addition, the PlatformLogger API can be used if the logging module does not exist. What use case required this ? Is this meant to be similar to Apache commons-logging which also has a basic logging functionality ? -import java.util.logging.Logger; +import sun.util.logging.PlatformLogger; And lastly it seems counter intuitive that a dependency would be change from a java.* - sun.*, why not add it under the java.* tree ? On 9/18/2009 9:51 PM, mandy.ch...@sun.com wrote: Changeset: d3281fa8e46c Author:mchung Date: 2009-09-17 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3281fa8e46c 6882376: Add internal support for JRE implementation to eliminate the dependency on logging Summary: Added sun.util.logging.PlatformLogger for JRE implementation to log messages. Reviewed-by: alanb, naoto ! make/java/logging/Makefile ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/LogRecord.java ! src/share/classes/sun/util/LocaleServiceProviderPool.java + src/share/classes/sun/util/logging/PlatformLogger.java ! src/windows/classes/java/util/prefs/WindowsPreferences.java + test/sun/util/logging/PlatformLoggerTest.java Changeset: 7b4e73ca6fd7 Author:mchung Date: 2009-09-18 17:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b4e73ca6fd7 Merge __ Information from ESET NOD32 Antivirus, version of virus signature database 4439 (20090918) __ The message was checked by ESET NOD32 Antivirus. http://www.eset.com
Re: hg: jdk7/tl/jdk: 2 new changesets
..Mandy, Three questions. -import java.util.logging.Logger; +import sun.util.logging.PlatformLogger; It seems counter intuitive that a dependency would be change from a java.* - sun.* since this the OpenJDK ,why not add it to java.util.log.* ? Then the JavaDocs says : This enables the runtime components to eliminate the static dependency of the logging facility In addition, the PlatformLogger API can be used if the logging module does not exist. What use case required this ? Then is this meant to be similar to Apache commons-logging which also has a basic logging functionality ? On 9/18/2009 9:51 PM, mandy.ch...@sun.com wrote: Changeset: d3281fa8e46c Author:mchung Date: 2009-09-17 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/d3281fa8e46c 6882376: Add internal support for JRE implementation to eliminate the dependency on logging Summary: Added sun.util.logging.PlatformLogger for JRE implementation to log messages. Reviewed-by: alanb, naoto ! make/java/logging/Makefile ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/LogRecord.java ! src/share/classes/sun/util/LocaleServiceProviderPool.java + src/share/classes/sun/util/logging/PlatformLogger.java ! src/windows/classes/java/util/prefs/WindowsPreferences.java + test/sun/util/logging/PlatformLoggerTest.java Changeset: 7b4e73ca6fd7 Author:mchung Date: 2009-09-18 17:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/7b4e73ca6fd7 Merge __ Information from ESET NOD32 Antivirus, version of virus signature database 4439 (20090918) __ The message was checked by ESET NOD32 Antivirus. http://www.eset.com
