Re: Review request: JDK-8167630 jdeps --generate-module-info forgets to close the resource after checking any unnamed package

2016-10-12 Thread Jonathan Bluett-Duncan
Not a reviewer, but looks good to me. :-) Kind regards, Jonathan On 12 Oct 2016 23:54, "Lance Andersen" wrote: > +1 > > On Oct 12, 2016, at 6:52 PM, Mandy Chung wrote: > > > > Simple patch close the ClassFileReader with try-with-resource. > > > > > > diff --git a/src/jdk.jdeps/share/classes/co

Re: Review request: JDK-8167630 jdeps --generate-module-info forgets to close the resource after checking any unnamed package

2016-10-12 Thread Lance Andersen
+1 > On Oct 12, 2016, at 6:52 PM, Mandy Chung wrote: > > Simple patch close the ClassFileReader with try-with-resource. > > > diff --git a/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java > b/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java > --- a/src/jdk.jdeps/sh

Review request: JDK-8167630 jdeps --generate-module-info forgets to close the resource after checking any unnamed package

2016-10-12 Thread Mandy Chung
Simple patch close the ClassFileReader with try-with-resource. diff --git a/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java b/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java --- a/src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java +++ b/src/jdk.jdeps/sh