Re: RFR: 8373118: Test java/lang/Thread/virtual/Starvation.java timed out [v25]
On Tue, 13 Jan 2026 15:57:34 GMT, Viktor Klang wrote:
>> Doug Lea has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix missing undo
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2591:
>
>> 2589: unlockRunState();
>> 2590: }
>> 2591: ForkJoinTask[] a;
>
> `a` is not used
Thanks for finding remnants of incomplete undo/redos!
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2593:
>
>> 2591: ForkJoinTask[] a;
>> 2592: if (q != null && (lock = q.tryLockPhase()) != 1) {
>> 2593: int unlock = lock + NEXTIDLE;
>
> Suggestion:
>
> int unlock = lock + NEXTIDLE;
Same
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2604:
>
>> 2602: throw new RejectedExecutionException();
>> 2603: }
>> 2604: private void poolSubmit(ForkJoinTask task, boolean
>> signalIfEmpty) {
>
> Suggestion:
>
>
> private void poolSubmit(ForkJoinTask task, boolean signalIfEmpty) {
And another one.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2690252073
PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2690253141
PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2690253986
Re: RFR: 8373118: Test java/lang/Thread/virtual/Starvation.java timed out [v25]
On Mon, 12 Jan 2026 17:44:22 GMT, Doug Lea wrote:
>> Changes signal filtering to avoid possible starvation
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix missing undo
src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2604:
> 2602: throw new RejectedExecutionException();
> 2603: }
> 2604: private void poolSubmit(ForkJoinTask task, boolean
> signalIfEmpty) {
Suggestion:
private void poolSubmit(ForkJoinTask task, boolean signalIfEmpty) {
-
PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2687114914
Re: RFR: 8373118: Test java/lang/Thread/virtual/Starvation.java timed out [v25]
On Mon, 12 Jan 2026 17:44:22 GMT, Doug Lea wrote:
>> Changes signal filtering to avoid possible starvation
>
> Doug Lea has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix missing undo
src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2591:
> 2589: unlockRunState();
> 2590: }
> 2591: ForkJoinTask[] a;
`a` is not used
src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2593:
> 2591: ForkJoinTask[] a;
> 2592: if (q != null && (lock = q.tryLockPhase()) != 1) {
> 2593: int unlock = lock + NEXTIDLE;
Suggestion:
int unlock = lock + NEXTIDLE;
-
PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2687038807
PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2687040332
Re: RFR: 8373118: Test java/lang/Thread/virtual/Starvation.java timed out [v25]
> Changes signal filtering to avoid possible starvation Doug Lea has updated the pull request incrementally with one additional commit since the last revision: Fix missing undo - Changes: - all: https://git.openjdk.org/jdk/pull/28797/files - new: https://git.openjdk.org/jdk/pull/28797/files/c3e137a6..bb492a04 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=28797&range=24 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28797&range=23-24 Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/28797.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/28797/head:pull/28797 PR: https://git.openjdk.org/jdk/pull/28797
