Re: RFR: 8374215: [macos] Clean "lic_template.plist" [v4]
> - Removed `plst`. It is not clear why we need it. > - I did not found official specification for this file, but based on some > research `plst` is not part of it. Other entries seems to be > required. > - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there are > no alternative for it. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: Added missing import from merge - Changes: - all: https://git.openjdk.org/jdk/pull/28959/files - new: https://git.openjdk.org/jdk/pull/28959/files/981066c2..3acafc5a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=28959&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28959&range=02-03 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/28959.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/28959/head:pull/28959 PR: https://git.openjdk.org/jdk/pull/28959
Re: RFR: 8374215: [macos] Clean "lic_template.plist" [v2]
> - Removed `plst`. It is not clear why we need it. > - I did not found official specification for this file, but based on some > research `plst` is not part of it. Other entries seems to be > required. > - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there are > no alternative for it. Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8374215: [macos] Clean "lic_template.plist" [v2] - Changes: - all: https://git.openjdk.org/jdk/pull/28959/files - new: https://git.openjdk.org/jdk/pull/28959/files/48763b1a..d8c3b0aa Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=28959&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28959&range=00-01 Stats: 241 lines in 6 files changed: 86 ins; 127 del; 28 mod Patch: https://git.openjdk.org/jdk/pull/28959.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/28959/head:pull/28959 PR: https://git.openjdk.org/jdk/pull/28959
Re: RFR: 8374215: [macos] Clean "lic_template.plist" [v3]
> - Removed `plst`. It is not clear why we need it. > - I did not found official specification for this file, but based on some > research `plst` is not part of it. Other entries seems to be > required. > - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there are > no alternative for it. Alexander Matveev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits: - merge upstream/master - 8374215: [macos] Clean "lic_template.plist" [v2] - 8374215: [macos] Clean "lic_template.plist" - Changes: https://git.openjdk.org/jdk/pull/28959/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28959&range=02 Stats: 246 lines in 6 files changed: 82 ins; 137 del; 27 mod Patch: https://git.openjdk.org/jdk/pull/28959.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/28959/head:pull/28959 PR: https://git.openjdk.org/jdk/pull/28959
Re: RFR: 8374215: [macos] Clean "lic_template.plist"
On Tue, 23 Dec 2025 02:49:22 GMT, Alexander Matveev wrote: > - Removed `plst`. It is not clear why we need it. > - I did not found official specification for this file, but based on some > research `plst` is not part of it. Other entries seems to be > required. > - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there are > no alternative for it. I don't support complicating jpackage with the warning. When `hdiutil udifrez` stops working, jpackage will start failing: https://github.com/openjdk/jdk/blob/ecb42341a94326b1ee85ddd7b9ebadce8c952b99/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgPackager.java#L417 We don't need anything extra. - PR Comment: https://git.openjdk.org/jdk/pull/28959#issuecomment-3685000102
Re: RFR: 8374215: [macos] Clean "lic_template.plist"
On Tue, 23 Dec 2025 02:49:22 GMT, Alexander Matveev wrote: > - Removed `plst`. It is not clear why we need it. > - I did not found official specification for this file, but based on some > research `plst` is not part of it. Other entries seems to be > required. > - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there are > no alternative for it. Do you have suggestion if we should issue warning for `DMG` and `--license-file` that it was deprecated and we will drop it as soon as `hdiutil` drops it? - PR Comment: https://git.openjdk.org/jdk/pull/28959#issuecomment-3684958332
Re: RFR: 8374215: [macos] Clean "lic_template.plist"
On Tue, 23 Dec 2025 03:18:47 GMT, Alexander Matveev wrote: > but moving them to l10n files is not really necessary, since we will never > change them. Right, but this way they will be out of the scope for the localization team. This is not right. Let's get it fixed properly and never touch it again until the `hdiutil udifrez` command is entirely broken. - PR Comment: https://git.openjdk.org/jdk/pull/28959#issuecomment-3684952429
Re: RFR: 8374215: [macos] Clean "lic_template.plist"
On Tue, 23 Dec 2025 03:13:05 GMT, Alexey Semenyuk wrote: > Should we spend time cleaning the "lic_template.plist" file and adding > complexity by moving resources to l10n files, or merely remove support for a > license file in DMG packaging? I'm on the fence. I think we should not remove it as long as it is supported by `hdiutil` in case if it is being used. For cleanup we should drop unsupported translations, but moving them to l10n files is not really necessary, since we will never change them. I will prefer drop translations, but do not move them to l10n files. - PR Comment: https://git.openjdk.org/jdk/pull/28959#issuecomment-3684929135
Re: RFR: 8374215: [macos] Clean "lic_template.plist"
On Tue, 23 Dec 2025 02:49:22 GMT, Alexander Matveev wrote: > NOTE: License dialog for DMG was deprecated since macOS 12. Also, there are > no alternative for it. Right, but `hdiutil udifrez` command is still working: [02:08:24.166] Running /usr/bin/hdiutil [02:08:24.194] Command [PID: 93201]: /usr/bin/hdiutil udifrez testCommon/output/CommonLicenseTest-1.0.dmg -xml /var/folders/xt/bm4_x23d1_s0kbvvls86_7z8gr/T/jdk.jpackage6799898339358549904/config/CommonLicenseTest-license.plist [02:08:24.194] Output: hdiutil: WARNING: udifrez is deprecated copying resource 'STR#' (5000)... copying resource 'STR#' (5001)... copying resource 'STR#' (5002)... copying resource 'STR#' (5003)... copying resource 'STR#' (5004)... copying resource 'STR#' (5005)... copying resource 'STR#' (5006)... copying resource 'STR#' (5007)... copying resource 'STR#' (5008)... copying resource 'STR#' (5009)... copying resource 'STR#' (5010)... copying resource 'STR#' (5011)... copying resource 'STR#' (5012)... copying resource 'STR#' (5013)... copying resource 'STR#' (5014)... copying resource 'STR#' (5015)... copying resource 'STR#' (5016)... copying resource 'TMPL' (128)... copying resource 'TEXT' (5000)... copying resource 'LPic' (5000)... copying resource 'styl' (5000)... copying resource 'plst' (0)... [02:08:24.195] Returned: 0 [02:08:24.195] Result DMG installer for CommonLicenseTest: testCommon/output/CommonLicenseTest-1.0.dmg. [02:08:24.196] Succeeded in building Mac DMG Package package [02:08:24.319] TRACE: exec: Done. Exit code: 0 Should we spend time cleaning the "lic_template.plist" file and adding complexity by moving resources to l10n files, or merely remove support for a license file in DMG packaging? I'm on the fence. - PR Comment: https://git.openjdk.org/jdk/pull/28959#issuecomment-3684915337
Re: RFR: 8374215: [macos] Clean "lic_template.plist"
On Tue, 23 Dec 2025 03:00:32 GMT, Alexey Semenyuk wrote: >> - Removed `plst`. It is not clear why we need it. >> - I did not found official specification for this file, but based on some >> research `plst` is not part of it. Other entries seems to be >> required. >> - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there >> are no alternative for it. > > src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/lic_template.plist > line 184: > >> 182: 0x >> 183: Data >> 184: >> AAYFTm9yc2sERW5pZwlJa2tlIGVuaWcIU2tyaXYgdXQKQXJraXZlci4uLqNIdmlzIERlIGVyIGVuaWcgaSBiZXN0ZW1tZWxzZW5lIGkgZGVubmUgbGlzZW5zYXZ0YWxlbiwga2xpa2tlciBEZSBwjCAiRW5pZyIta25hcHBlbiBmb3IgjCBpbnN0YWxsZXJlIHByb2dyYW12YXJlbi4gSHZpcyBEZSBpa2tlIGVyIGVuaWcsIGtsaWtrZXIgRGUgcIwgIklra2UgZW5pZyIu > > I suppose this is a base64-encoded Norwegian translation of something. We > don't support Norwegian l10n. > > Supported l10n-s should be in .properties files and encoded as base64 at > runtime. I will drop all translations except `de`, `ja`, `zh_CN` and move them to .properties files. - PR Review Comment: https://git.openjdk.org/jdk/pull/28959#discussion_r2641786661
Re: RFR: 8374215: [macos] Clean "lic_template.plist"
On Tue, 23 Dec 2025 02:49:22 GMT, Alexander Matveev wrote: > - Removed `plst`. It is not clear why we need it. > - I did not found official specification for this file, but based on some > research `plst` is not part of it. Other entries seems to be > required. > - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there are > no alternative for it. @alexeysemenyukoracle Please review. - PR Comment: https://git.openjdk.org/jdk/pull/28959#issuecomment-3684859375
Re: RFR: 8374215: [macos] Clean "lic_template.plist"
On Tue, 23 Dec 2025 02:49:22 GMT, Alexander Matveev wrote: > - Removed `plst`. It is not clear why we need it. > - I did not found official specification for this file, but based on some > research `plst` is not part of it. Other entries seems to be > required. > - NOTE: License dialog for DMG was deprecated since macOS 12. Also, there are > no alternative for it. Changes requested by asemenyuk (Reviewer). src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/lic_template.plist line 184: > 182: 0x > 183: Data > 184: > AAYFTm9yc2sERW5pZwlJa2tlIGVuaWcIU2tyaXYgdXQKQXJraXZlci4uLqNIdmlzIERlIGVyIGVuaWcgaSBiZXN0ZW1tZWxzZW5lIGkgZGVubmUgbGlzZW5zYXZ0YWxlbiwga2xpa2tlciBEZSBwjCAiRW5pZyIta25hcHBlbiBmb3IgjCBpbnN0YWxsZXJlIHByb2dyYW12YXJlbi4gSHZpcyBEZSBpa2tlIGVyIGVuaWcsIGtsaWtrZXIgRGUgcIwgIklra2UgZW5pZyIu I suppose this is a base64-encoded Norwegian translation of something. We don't support Norwegian l10n. Supported l10n-s should be in .properties files and encoded as base64 at runtime. - PR Review: https://git.openjdk.org/jdk/pull/28959#pullrequestreview-3606363972 PR Review Comment: https://git.openjdk.org/jdk/pull/28959#discussion_r2641780135
