Re: RFR: 8376751: add preview project anchors to main-line ProblemList files
On Fri, 30 Jan 2026 21:40:15 GMT, Vladimir Kozlov wrote: >> A trivial fix to add preview project anchors to main-line ProblemList files. >> >> Also backports changes from the Valhalla repo to make/RunTests.gmk >> to support ProblemList-coh.txt files. This PR also includes the new >> ProblemList-coh.txt file, but it contains no entries (yet). Since this is >> NOT a complete backport of the changes for: >> >> - [JDK-8375337](https://bugs.openjdk.org/browse/JDK-8375337) [lworld] >> ProblemList misc svc tests that fail due to JDK-8375332 >> >> I'm not handling it as a backport issue. >> >> I've also added missing Copyright headers to some files. > > Marked as reviewed by kvn (Reviewer). @vnkozlov, @liach, and @RogerRiggs - Thanks for the reviews! - PR Comment: https://git.openjdk.org/jdk/pull/29509#issuecomment-3826088183
Re: RFR: 8376751: add preview project anchors to main-line ProblemList files
On Fri, 30 Jan 2026 22:04:58 GMT, Daniel D. Daugherty wrote: >> test/langtools/ProblemList-enable-preview.txt line 2: >> >>> 1: # >>> 2: # Copyright (c) 2025, 2026, Oracle and/or its affiliates. All rights >>> reserved. >> >> Suggestion: >> >> # Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved. > > Good catch. In the main-line repo the file is new in 2026, but in the > Valhalla repo, the proper copyright is "2025, 2026"... Sure, we can inherit the valhalla copyright years. - PR Review Comment: https://git.openjdk.org/jdk/pull/29509#discussion_r2748166677
Re: RFR: 8376751: add preview project anchors to main-line ProblemList files
On Fri, 30 Jan 2026 20:31:36 GMT, Daniel D. Daugherty wrote: > A trivial fix to add preview project anchors to main-line ProblemList files. > > Also backports changes from the Valhalla repo to make/RunTests.gmk > to support ProblemList-coh.txt files. This PR also includes the new > ProblemList-coh.txt file, but it contains no entries (yet). Since this is > NOT a complete backport of the changes for: > > - [JDK-8375337](https://bugs.openjdk.org/browse/JDK-8375337) [lworld] > ProblemList misc svc tests that fail due to JDK-8375332 > > I'm not handling it as a backport issue. > > I've also added missing Copyright headers to some files. Marked as reviewed by liach (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/29509#pullrequestreview-3730624896
Re: RFR: 8376751: add preview project anchors to main-line ProblemList files
On Fri, 30 Jan 2026 21:40:57 GMT, Chen Liang wrote: >> A trivial fix to add preview project anchors to main-line ProblemList files. >> >> Also backports changes from the Valhalla repo to make/RunTests.gmk >> to support ProblemList-coh.txt files. This PR also includes the new >> ProblemList-coh.txt file, but it contains no entries (yet). Since this is >> NOT a complete backport of the changes for: >> >> - [JDK-8375337](https://bugs.openjdk.org/browse/JDK-8375337) [lworld] >> ProblemList misc svc tests that fail due to JDK-8375332 >> >> I'm not handling it as a backport issue. >> >> I've also added missing Copyright headers to some files. > > test/langtools/ProblemList-enable-preview.txt line 2: > >> 1: # >> 2: # Copyright (c) 2025, 2026, Oracle and/or its affiliates. All rights >> reserved. > > Suggestion: > > # Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved. Good catch. In the main-line repo the file is new in 2026, but in the Valhalla repo, the proper copyright is "2025, 2026"... - PR Review Comment: https://git.openjdk.org/jdk/pull/29509#discussion_r2748155579
Re: RFR: 8376751: add preview project anchors to main-line ProblemList files
On Fri, 30 Jan 2026 20:31:36 GMT, Daniel D. Daugherty wrote: > A trivial fix to add preview project anchors to main-line ProblemList files. > > Also backports changes from the Valhalla repo to make/RunTests.gmk > to support ProblemList-coh.txt files. This PR also includes the new > ProblemList-coh.txt file, but it contains no entries (yet). Since this is > NOT a complete backport of the changes for: > > - [JDK-8375337](https://bugs.openjdk.org/browse/JDK-8375337) [lworld] > ProblemList misc svc tests that fail due to JDK-8375332 > > I'm not handling it as a backport issue. > > I've also added missing Copyright headers to some files. Marked as reviewed by rriggs (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/29509#pullrequestreview-3730618431
Re: RFR: 8376751: add preview project anchors to main-line ProblemList files
On Fri, 30 Jan 2026 20:31:36 GMT, Daniel D. Daugherty wrote: > A trivial fix to add preview project anchors to main-line ProblemList files. > > Also backports changes from the Valhalla repo to make/RunTests.gmk > to support ProblemList-coh.txt files. This PR also includes the new > ProblemList-coh.txt file, but it contains no entries (yet). Since this is > NOT a complete backport of the changes for: > > - [JDK-8375337](https://bugs.openjdk.org/browse/JDK-8375337) [lworld] > ProblemList misc svc tests that fail due to JDK-8375332 > > I'm not handling it as a backport issue. > > I've also added missing Copyright headers to some files. Marked as reviewed by kvn (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/29509#pullrequestreview-3730502656
Re: RFR: 8376751: add preview project anchors to main-line ProblemList files
On Fri, 30 Jan 2026 20:31:36 GMT, Daniel D. Daugherty wrote: > A trivial fix to add preview project anchors to main-line ProblemList files. > > Also backports changes from the Valhalla repo to make/RunTests.gmk > to support ProblemList-coh.txt files. This PR also includes the new > ProblemList-coh.txt file, but it contains no entries (yet). Since this is > NOT a complete backport of the changes for: > > - [JDK-8375337](https://bugs.openjdk.org/browse/JDK-8375337) [lworld] > ProblemList misc svc tests that fail due to JDK-8375332 > > I'm not handling it as a backport issue. > > I've also added missing Copyright headers to some files. test/langtools/ProblemList-enable-preview.txt line 2: > 1: # > 2: # Copyright (c) 2025, 2026, Oracle and/or its affiliates. All rights > reserved. Suggestion: # Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved. - PR Review Comment: https://git.openjdk.org/jdk/pull/29509#discussion_r2748067121
