Re: [core-workflow] Use something other than an In-joke for Trigger Phrases

2017-10-10 Thread Ethan Furman
On 10/08/2017 09:44 AM, Brett Cannon wrote: I actually wouldn't want the bot name in the trigger phrase since you're not addressing the bot but the reviewer(s). So using something that is unambiguous as a trigger phrase like "please re-review" or "please review again" that won't come up in con

Re: [core-workflow] Use something other than an In-joke for Trigger Phrases

2017-10-10 Thread Brett Cannon
I just merged the PR and went with "I have made the requested changes; please review again". Figured this makes people aware that they are to have addressed the changes before requesting a review and has them saying "please". :) Plus there's no way anyone will accidentally type that in conversation

Re: [core-workflow] Use something other than an In-joke for Trigger Phrases

2017-10-10 Thread Ethan Furman
On 10/10/2017 11:51 AM, Brett Cannon wrote: I just merged the PR and went with "I have made the requested changes; please review again". Figured this makes people aware that they are to have addressed the changes before requesting a review and has them saying "please". :) Plus there's no way a