Re: [coreboot] baytrail + fsp_baytrail

2015-12-07 Thread Peter Stuge
ron minnich wrote: > nobody cared enough to really do the work That's the problem - not the solution. Don't build infrastructure to support complacency, build infrastructure to support desirable activity. //Peter -- coreboot mailing list: coreboot@coreboot.org

Re: [coreboot] baytrail + fsp_baytrail

2015-12-07 Thread Martin Roth
I think we can cut down on some of the code redundancy, but as Alex says, they are different chipsets, and we need to be careful about trying to combine too much. Here are my suggested steps: 1) Look for commonalities between baytrail and other chipsets and move pieces things into

Re: [coreboot] baytrail + fsp_baytrail

2015-12-07 Thread Ben Gardner
On Mon, Dec 7, 2015 at 9:55 AM, Martin Roth wrote: > I think we can cut down on some of the code redundancy, but as Alex > says, they are different chipsets, and we need to be careful about > trying to combine too much. > > Here are my suggested steps: > 1) Look for

Re: [coreboot] baytrail + fsp_baytrail

2015-12-07 Thread Alex G.
On 12/07/2015 07:55 AM, Martin Roth wrote: > Here are my suggested steps: > 1) Look for commonalities between baytrail and other chipsets and move > pieces things into soc/intel/common A word of caution about soc/intel/common: it's a misnomer. It's very specific to FSP 1.1. Alex -- coreboot

Re: [coreboot] baytrail + fsp_baytrail

2015-12-07 Thread Alex G.
On 12/07/2015 06:34 PM, Alex G. wrote: > On 12/07/2015 07:55 AM, Martin Roth wrote: >> Here are my suggested steps: >> 1) Look for commonalities between baytrail and other chipsets and move >> pieces things into soc/intel/common > > A word of caution about soc/intel/common: it's a misnomer.

Re: [coreboot] baytrail + fsp_baytrail

2015-12-07 Thread ron minnich
there's another way to do this that few people use. Back in the E7500 days, the 7505 came along. We experimented with this: src/northbridge/intel/e750x and put the common files in there. Under e750x we had e7500 e7505 for the different files. so, src/northbridge/intel/e750x/{e7500,e7505} worked